MAGETWO-66480: [GITHUB] URL key for specified store already exists #6671

- changed bad naming

Author: cpartica

lib/internal/Magento/Framework/Message/ExceptionMessageFactoryPool.php

@@ -15,6 +15,14 @@ class ExceptionMessageFactoryPool
      */
     private $exceptionMessageFactoryMap = [];
 
+
+    /**
+     * Key of instance is the exception format parameter
+     *
+     * @var ExceptionMessageFactoryInterface
+     */
+    private $defaultExceptionMessageFactory = [];
+
     /**
      * @param ExceptionMessageFactoryInterface $defaultExceptionMessageFactory
      * @param ExceptionMessageFactoryInterface[] $exceptionMessageFactoryMap
@@ -23,7 +31,7 @@ public function __construct(
         ExceptionMessageFactoryInterface $defaultExceptionMessageFactory,
         array $exceptionMessageFactoryMap = []
     ) {
-        $this->defaultConfiguration = $defaultExceptionMessageFactory;
+        $this->defaultExceptionMessageFactory = $defaultExceptionMessageFactory;
         $this->exceptionMessageFactoryMap = $exceptionMessageFactoryMap;
     }
 
@@ -38,6 +46,6 @@ public function getMessageFactory(\Exception $exception)
         if (isset($this->exceptionMessageFactoryMap[get_class($exception)])) {
             return $this->exceptionMessageFactoryMap[get_class($exception)];
         }
-        return $this->defaultConfiguration;
+        return $this->defaultExceptionMessageFactory;
     }
 }

lib/internal/Magento/Framework/Message/Test/Unit/ExceptionMessageFactoryPoolTest.php

@@ -17,9 +17,9 @@ class ExceptionMessageFactoryPoolTest extends \PHPUnit_Framework_TestCase
     private $defaultExceptionMessageFactoryMock;
 
     /**
-     * @var \Magento\Framework\Message\ExceptionMessageFactoryPool
+     * @var \Magento\Framework\Message\ExceptionMessageFactoryInterface
      */
-    private $specificExceptionMessageFactoryPoolMock;
+    private $specificExceptionMessageFactoryMock;
 
     /**
      * @var ExceptionMessageFactoryInterface[] | \PHPUnit_Framework_MockObject_MockObject
@@ -33,11 +33,11 @@ class ExceptionMessageFactoryPoolTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->specificExceptionMessageFactoryPoolMock = $this->getMock(ExceptionMessageFactoryInterface::class);
+        $this->specificExceptionMessageFactoryMock = $this->getMock(ExceptionMessageFactoryInterface::class);
         $this->defaultExceptionMessageFactoryMock = $this->getMock(ExceptionMessageFactoryInterface::class);
 
         $this->exceptionMessageFactoryMapMock = [
-            \Magento\Framework\Exception\LocalizedException::class => $this->specificExceptionMessageFactoryPoolMock
+            \Magento\Framework\Exception\LocalizedException::class => $this->specificExceptionMessageFactoryMock
         ];
         $this->exceptionMessageFactoryPool = new \Magento\Framework\Message\ExceptionMessageFactoryPool(
             $this->defaultExceptionMessageFactoryMock,
@@ -58,7 +58,7 @@ public function testSuccessfulSpecificCreateMessage()
     {
         $localizedException = new LocalizedException(__('message'));
         $this->assertEquals(
-            $this->specificExceptionMessageFactoryPoolMock,
+            $this->specificExceptionMessageFactoryMock,
             $this->exceptionMessageFactoryPool->getMessageFactory($localizedException)
         );
     }

lib/internal/Magento/Framework/Message/Test/Unit/ExceptionMessageLookupFactoryTest.php

@@ -46,7 +46,7 @@ protected function setUp()
         );
     }
 
-    public function test()
+    public function testCreateMessage()
     {
         $exceptionMessage = 'exception message';
         $exception = new \Exception($exceptionMessage);