Skip to content

Commit ba2a0de

Browse files
author
Robert He
committed
MAGETWO-32410: Grouped Product Integration API
- fixes from code review
1 parent f428383 commit ba2a0de

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -766,15 +766,6 @@ public function testGetProductLinks()
766766
$inputRelatedLink->setData("type", "simple");
767767
$inputRelatedLink->setPosition(0);
768768

769-
$customData = ["attribute_code" => "qty", "value" => 1];
770-
$inputGroupLink = $this->objectManagerHelper->getObject('Magento\Catalog\Model\ProductLink\Link');
771-
$inputGroupLink->setProductSku("Simple Product 1");
772-
$inputGroupLink->setLinkType("associated");
773-
$inputGroupLink->setData("sku", "Simple Product 2");
774-
$inputGroupLink->setData("type", "simple");
775-
$inputGroupLink->setPosition(0);
776-
$inputGroupLink["custom_attributes"] = [$customData];
777-
778769
$outputRelatedLink = $this->objectManagerHelper->getObject('Magento\Catalog\Model\ProductLink\Link');
779770
$outputRelatedLink->setProductSku("Simple Product 1");
780771
$outputRelatedLink->setLinkType("related");

app/code/Magento/GroupedProduct/Test/Unit/Model/ProductTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,11 @@ public function testGetProductLinks()
363363
$outputRelatedLink->setPosition(0);
364364

365365
$groupExtension = $this->objectManagerHelper->getObject('Magento\Catalog\Api\Data\ProductLinkExtension');
366-
$groupExtension->setQty(1);
366+
$reflectionOfUser = new \ReflectionClass('Magento\Catalog\Api\Data\ProductLinkExtension');
367+
$method = $reflectionOfUser->getMethod('setData');
368+
$method->setAccessible(true);
369+
$method->invokeArgs($groupExtension, array('qty', 1));
370+
367371
$outputGroupLink = $this->objectManagerHelper->getObject('Magento\Catalog\Model\ProductLink\Link');
368372
$outputGroupLink->setProductSku("Simple Product 1");
369373
$outputGroupLink->setLinkType("associated");
@@ -409,7 +413,6 @@ public function testGetProductLinks()
409413

410414
$extension = $this->objectManagerHelper->getObject('Magento\Catalog\Api\Data\ProductLinkExtension');
411415
$productLink2->setExtensionAttributes($extension);
412-
$productLink2->setExtensionAttributes($extension);
413416

414417
$links = $this->model->getProductLinks();
415418
$this->assertEquals($links, $expectedOutput);

0 commit comments

Comments
 (0)