Skip to content

Commit ba126b3

Browse files
author
Oleksandr Gorkun
committed
MAGETWO-65466: [Backport] - Issue when deleting item from Product options grid containing more than 20 options - for 2.1
1 parent c2fa238 commit ba126b3

File tree

2 files changed

+21
-5
lines changed
  • app/code/Magento/Catalog
    • Controller/Adminhtml/Product/Initialization
    • Test/Unit/Controller/Adminhtml/Product/Initialization

2 files changed

+21
-5
lines changed

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ private function fillProductOptions(Product $product, array $productOptions)
453453
continue;
454454
}
455455

456+
//Ignoring ID because front-end messes it up.
456457
$customOptionData['option_id'] = null;
457458
if (isset($customOptionData['values'])) {
458459
$customOptionData['values'] = array_filter(

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Initialization/HelperTest.php

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,10 @@ private function assembleProductMock($links = [])
293293
->method('create')
294294
->willReturnMap([
295295
[
296-
['data' => $optionsData['option2']],
296+
['data' => array_merge($optionsData['option2'], ['option_id' => null])],
297297
$customOptionMockClone1->setData($optionsData['option2'])
298298
], [
299-
['data' => $optionsData['option3']],
299+
['data' => array_merge($optionsData['option3'], ['option_id' => null])],
300300
$customOptionMockClone2->setData($optionsData['option3'])
301301
]
302302
]);
@@ -719,9 +719,24 @@ private function assembleProductRepositoryMock($links)
719719
private function getOptionsData()
720720
{
721721
$optionsData = [
722-
'option1' => ['is_delete' => true, 'name' => 'name1', 'price' => 'price1', 'option_id' => ''],
723-
'option2' => ['is_delete' => false, 'name' => 'name1', 'price' => 'price1', 'option_id' => '13'],
724-
'option3' => ['is_delete' => false, 'name' => 'name1', 'price' => 'price1', 'option_id' => '14'],
722+
'option1' => [
723+
'is_delete' => true,
724+
'name' => 'name1',
725+
'price' => 'price1',
726+
'option_id' => '',
727+
],
728+
'option2' => [
729+
'is_delete' => false,
730+
'name' => 'name2',
731+
'price' => 'price1',
732+
'option_id' => '13',
733+
],
734+
'option3' => [
735+
'is_delete' => false,
736+
'name' => 'name1',
737+
'price' => 'price1',
738+
'option_id' => '14',
739+
],
725740
];
726741

727742
return $optionsData;

0 commit comments

Comments
 (0)