Skip to content

Commit ba0e138

Browse files
ACQE-5709 : Optimized cart price rule creation
1 parent 110dbd5 commit ba0e138

File tree

1 file changed

+9
-22
lines changed

1 file changed

+9
-22
lines changed

app/code/Magento/Paypal/Test/Mftf/Test/StorefrontPaypalExpressCheckoutWithDiscountCouponTest.xml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17,30 +17,18 @@
1717
<testCaseId value="AC-6152"/>
1818
</annotations>
1919
<before>
20-
<!-- Simple product is created and assigned to category -->
21-
<createData entity="_defaultCategory" stepKey="createCategory"/>
22-
<createData entity="SimpleProduct" stepKey="createProduct">
23-
<requiredEntity createDataKey="createCategory"/>
24-
</createData>
20+
<!-- Simple product is created -->
21+
<createData entity="SimpleProduct" stepKey="createProduct"/>
2522
<!-- US Customer is created -->
2623
<createData entity="Simple_US_Customer" stepKey="createCustomer"/>
2724
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
2825
<!-- Delete all existing cart price rules -->
2926
<actionGroup ref="AdminCartPriceRuleDeleteAllActionGroup" stepKey="deleteAllCartPriceRules"/>
3027
<!-- Create new cart price rule -->
31-
<actionGroup ref="AdminOpenNewCartPriceRuleFormPageActionGroup" stepKey="createCartPriceRule"/>
32-
<actionGroup ref="AdminCartPriceRuleFillMainInfoActionGroup" stepKey="fillCartRulesMainInfoPage">
33-
<argument name="name" value="{{CatPriceRule.name}}"/>
34-
<argument name="description" value="{{ApiSalesRule.description}}"/>
35-
</actionGroup>
36-
<!-- Add discount coupon -->
37-
<actionGroup ref="AdminCartPriceRuleFillCouponInfoActionGroup" stepKey="fillCartPriceRuleCouponInfo"/>
38-
<!-- Actions header configurations -->
39-
<conditionalClick selector="{{AdminCartPriceRulesFormSection.actionsHeader}}" dependentSelector="{{AdminCartPriceRulesFormSection.actionsHeader}}" visible="true" stepKey="clickToExpandActions"/>
40-
<selectOption selector="{{AdminCartPriceRulesFormSection.apply}}" userInput="Percent of product price discount" stepKey="selectActionType"/>
41-
<fillField selector="{{AdminCartPriceRulesFormSection.discountAmount}}" userInput="20" stepKey="fillDiscountAmount"/>
42-
<actionGroup ref="AdminCartPriceRuleSaveActionGroup" stepKey="saveCartPriceRule"/>
43-
<!-- end of create cart price rule -->
28+
<createData entity="SalesRuleSpecificCouponWithPercentDiscount" stepKey="createCartPriceRule"/>
29+
<createData entity="SimpleSalesRuleCoupon" stepKey="createCouponForCartPriceRule">
30+
<requiredEntity createDataKey="createCartPriceRule"/>
31+
</createData>
4432
<!-- Configure Paypal Express Checkout -->
4533
<actionGroup ref="AdminPayPalExpressCheckoutEnableActionGroup" stepKey="ConfigPayPalExpress">
4634
<argument name="credentials" value="SamplePaypalExpressConfig2"/>
@@ -50,7 +38,6 @@
5038
<magentoCLI command="config:set payment/paypal_express/active 0" stepKey="disablePayPalExpress"/>
5139
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
5240
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
53-
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
5441
<actionGroup ref="DeleteCartPriceRuleByName" stepKey="deleteCartPriceRule">
5542
<argument name="ruleName" value="{{CatPriceRule.name}}"/>
5643
</actionGroup>
@@ -74,18 +61,18 @@
7461
</actionGroup>
7562
<!-- Apply Discount Coupon to the Order and assert order total -->
7663
<actionGroup ref="StorefrontApplyDiscountCodeActionGroup" stepKey="applyDiscountCoupon">
77-
<argument name="discountCode" value="{{_defaultCoupon.code}}"/>
64+
<argument name="discountCode" value="$$createCouponForCartPriceRule.code$$"/>
7865
</actionGroup>
7966
<actionGroup ref="AssertStorefrontCheckoutPaymentSummaryTotalActionGroup" stepKey="assertSummaryTotalAfterCoupon">
80-
<argument name="orderTotal" value="$103.40"/>
67+
<argument name="orderTotal" value="$110.70"/>
8168
</actionGroup>
8269
<!-- Click on PayPal payment radio button -->
8370
<waitForElementClickable selector="{{CheckoutPaymentSection.PayPalPaymentRadio}}" stepKey="waitForPayPalRadioButton"/>
8471
<click selector="{{CheckoutPaymentSection.PayPalPaymentRadio}}" stepKey="selectPaypalPayment"/>
8572
<actionGroup ref="SwitchToPayPalGroupBtnActionGroup" stepKey="clickPayPalBtn"/>
8673
<!-- Login to Paypal in-context and verify order total on paypal page-->
8774
<actionGroup ref="StorefrontLoginToPayPalPaymentAccountTwoStepActionGroup" stepKey="loginToPayPal"/>
88-
<waitForText selector="{{PayPalPaymentSection.orderTotalOnPaypalCheckout}}" userInput="$103.40" stepKey="verifyOrderTotalOnPaypalPage"/>
75+
<waitForText selector="{{PayPalPaymentSection.orderTotalOnPaypalCheckout}}" userInput="$110.70" stepKey="verifyOrderTotalOnPaypalPage"/>
8976
<!-- Click PayPal button and go back to Magento site -->
9077
<actionGroup ref="StorefrontPaypalSwitchBackToMagentoFromCheckoutPageActionGroup" stepKey="confirmPaymentAndGoBackToMagento"/>
9178
<!-- I see order successful Page -->

0 commit comments

Comments
 (0)