merge magento/2.3.2-develop into magento-qwerty/MC-16089

Author: magento-cicd2

app/code/Magento/Authorization/Model/Role.php

@@ -40,7 +40,7 @@ class Role extends \Magento\Framework\Model\AbstractModel
      * @param \Magento\Authorization\Model\ResourceModel\Role\Collection $resourceCollection
      * @param array $data
      */
-    public function __construct(
+    public function __construct( //phpcs:ignore Generic.CodeAnalysis.UselessOverridingMethod
         \Magento\Framework\Model\Context $context,
         \Magento\Framework\Registry $registry,
         \Magento\Authorization\Model\ResourceModel\Role $resource,
@@ -52,28 +52,18 @@ public function __construct(
 
     /**
      * @inheritDoc
-     *
-     * @SuppressWarnings(PHPMD.SerializationAware)
-     * @deprecated Do not use PHP serialization.
      */
     public function __sleep()
     {
-        trigger_error('Using PHP serialization is deprecated', E_USER_DEPRECATED);
-
         $properties = parent::__sleep();
         return array_diff($properties, ['_resource', '_resourceCollection']);
     }
 
     /**
      * @inheritDoc
-     *
-     * @SuppressWarnings(PHPMD.SerializationAware)
-     * @deprecated Do not use PHP serialization.
      */
     public function __wakeup()
     {
-        trigger_error('Using PHP serialization is deprecated', E_USER_DEPRECATED);
-
         parent::__wakeup();
         $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
         $this->_resource = $objectManager->get(\Magento\Authorization\Model\ResourceModel\Role::class);

app/code/Magento/Backend/Model/Auth/Session.php

@@ -5,20 +5,17 @@
  */
 namespace Magento\Backend\Model\Auth;
 
-use Magento\Framework\Acl;
-use Magento\Framework\AclFactory;
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
 use Magento\Framework\Stdlib\CookieManagerInterface;
-use Magento\Backend\Spi\SessionUserHydratorInterface;
-use Magento\Backend\Spi\SessionAclHydratorInterface;
-use Magento\User\Model\User;
-use Magento\User\Model\UserFactory;
 
 /**
  * Backend Auth session model
  *
  * @api
+ * @method \Magento\User\Model\User|null getUser()
+ * @method \Magento\Backend\Model\Auth\Session setUser(\Magento\User\Model\User $value)
+ * @method \Magento\Framework\Acl|null getAcl()
+ * @method \Magento\Backend\Model\Auth\Session setAcl(\Magento\Framework\Acl $value)
  * @method int getUpdatedAt()
  * @method \Magento\Backend\Model\Auth\Session setUpdatedAt(int $value)
  *
@@ -59,36 +56,6 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
      */
     protected $_config;
 
-    /**
-     * @var SessionUserHydratorInterface
-     */
-    private $userHydrator;
-
-    /**
-     * @var SessionAclHydratorInterface
-     */
-    private $aclHydrator;
-
-    /**
-     * @var UserFactory
-     */
-    private $userFactory;
-
-    /**
-     * @var AclFactory
-     */
-    private $aclFactory;
-
-    /**
-     * @var User|null
-     */
-    private $user;
-
-    /**
-     * @var Acl|null
-     */
-    private $acl;
-
     /**
      * @param \Magento\Framework\App\Request\Http $request
      * @param \Magento\Framework\Session\SidResolverInterface $sidResolver
@@ -103,10 +70,6 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
      * @param \Magento\Backend\Model\UrlInterface $backendUrl
      * @param \Magento\Backend\App\ConfigInterface $config
      * @throws \Magento\Framework\Exception\SessionException
-     * @param SessionUserHydratorInterface|null $userHydrator
-     * @param SessionAclHydratorInterface|null $aclHydrator
-     * @param UserFactory|null $userFactory
-     * @param AclFactory|null $aclFactory
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -121,19 +84,11 @@ public function __construct(
         \Magento\Framework\App\State $appState,
         \Magento\Framework\Acl\Builder $aclBuilder,
         \Magento\Backend\Model\UrlInterface $backendUrl,
-        \Magento\Backend\App\ConfigInterface $config,
-        ?SessionUserHydratorInterface $userHydrator = null,
-        ?SessionAclHydratorInterface $aclHydrator = null,
-        ?UserFactory $userFactory = null,
-        ?AclFactory $aclFactory = null
+        \Magento\Backend\App\ConfigInterface $config
     ) {
         $this->_config = $config;
         $this->_aclBuilder = $aclBuilder;
         $this->_backendUrl = $backendUrl;
-        $this->userHydrator = $userHydrator ?? ObjectManager::getInstance()->get(SessionUserHydratorInterface::class);
-        $this->aclHydrator = $aclHydrator ?? ObjectManager::getInstance()->get(SessionAclHydratorInterface::class);
-        $this->userFactory = $userFactory ?? ObjectManager::getInstance()->get(UserFactory::class);
-        $this->aclFactory = $aclFactory ?? ObjectManager::getInstance()->get(AclFactory::class);
         parent::__construct(
             $request,
             $sidResolver,
@@ -192,6 +147,7 @@ public function isAllowed($resource, $privilege = null)
                         return $acl->isAllowed($user->getAclRole(), null, $privilege);
                     }
                 } catch (\Exception $e) {
+                    return false;
                 }
             }
         }
@@ -276,16 +232,6 @@ public function processLogin()
         return $this;
     }
 
-    /**
-     * @inheritDoc
-     */
-    public function destroy(array $options = null)
-    {
-        $this->user = null;
-        $this->acl = null;
-        parent::destroy($options);
-    }
-
     /**
      * Process of configuring of current auth storage when logout was performed
      *
@@ -309,136 +255,4 @@ public function isValidForPath($path)
     {
         return true;
     }
-
-    /**
-     * Logged-in user.
-     *
-     * @return User|null
-     */
-    public function getUser()
-    {
-        if (!$this->user) {
-            $userData = $this->getUserData();
-            if ($userData) {
-                /** @var User $user */
-                $user = $this->userFactory->create();
-                $this->userHydrator->hydrate($user, $userData);
-                $this->user = $user;
-            }
-        }
-
-        return $this->user;
-    }
-
-    /**
-     * Set logged-in user instance.
-     *
-     * @param User|null $user
-     * @return Session
-     */
-    public function setUser($user)
-    {
-        $this->setUserData(null);
-        if ($user) {
-            $this->setUserData($this->userHydrator->extract($user));
-        }
-        $this->user = $user;
-
-        return $this;
-    }
-
-    /**
-     * Is user logged in?
-     *
-     * @return bool
-     */
-    public function hasUser()
-    {
-        return $this->user || $this->hasUserData();
-    }
-
-    /**
-     * Remove logged-in user.
-     *
-     * @return Session
-     */
-    public function unsUser()
-    {
-        $this->user = null;
-        return $this->unsUserData();
-    }
-
-    /**
-     * Logged-in user's ACL data.
-     *
-     * @return Acl|null
-     */
-    public function getAcl()
-    {
-        if (!$this->acl) {
-            $aclData = $this->getUserAclData();
-            if ($aclData) {
-                /** @var Acl $acl */
-                $acl = $this->aclFactory->create();
-                $this->aclHydrator->hydrate($acl, $aclData);
-                $this->acl = $acl;
-            }
-        }
-
-        return $this->acl;
-    }
-
-    /**
-     * Set logged-in user's ACL data instance.
-     *
-     * @param Acl|null $acl
-     * @return Session
-     */
-    public function setAcl($acl)
-    {
-        $this->setUserAclData(null);
-        if ($acl) {
-            $this->setUserAclData($this->aclHydrator->extract($acl));
-        }
-        $this->acl = $acl;
-
-        return $this;
-    }
-
-    /**
-     * Whether ACL data is present.
-     *
-     * @return bool
-     */
-    public function hasAcl()
-    {
-        return $this->acl || $this->hasUserAclData();
-    }
-
-    /**
-     * Remove ACL data.
-     *
-     * @return Session
-     */
-    public function unsAcl()
-    {
-        $this->acl = null;
-        return $this->unsUserAclData();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function writeClose()
-    {
-        //Updating data in session in case these objects has been changed.
-        if ($this->user) {
-            $this->setUser($this->user);
-        }
-        if ($this->acl) {
-            $this->setAcl($this->acl);
-        }
-
-        parent::writeClose();
-    }
 }