Skip to content

Commit b9d0826

Browse files
author
Alex Bomko
committed
MAGETWO-36955: Pull request, Nord team sprint 20
- fix tests
1 parent 630ef03 commit b9d0826

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

app/code/Magento/Newsletter/Block/Adminhtml/Queue/Preview.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ class Preview extends \Magento\Newsletter\Block\Adminhtml\Template\Preview
3333
public function __construct(
3434
\Magento\Backend\Block\Template\Context $context,
3535
\Magento\Newsletter\Model\TemplateFactory $templateFactory,
36-
\Magento\Newsletter\Model\QueueFactory $queueFactory,
3736
\Magento\Newsletter\Model\SubscriberFactory $subscriberFactory,
37+
\Magento\Newsletter\Model\QueueFactory $queueFactory,
3838
array $data = []
3939
) {
4040
$this->_queueFactory = $queueFactory;

app/code/Magento/Review/Model/Resource/Rating.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ protected function processRatingStores(\Magento\Framework\Model\AbstractModel $o
214214

215215
$insert = [];
216216
foreach (array_diff_assoc($new, $old) as $storeId => $title) {
217-
$insert[] = ['rating_id' => $ratingId, 'store_id' => (int)$storeId];
217+
$insert[] = ['rating_id' => $ratingId, 'store_id' => (int)$storeId, 'value' => $title];
218218
}
219219
$this->insertRatingData($table, $insert);
220220
return $this;

dev/tests/integration/testsuite/Magento/Review/Model/Resource/Rating/CollectionTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,4 @@ public function testSetStoreFilter()
5151
{
5252
$this->collection->setStoreFilter(1);
5353
}
54-
5554
}

lib/internal/Magento/Framework/App/Rss/UrlBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
class UrlBuilder implements UrlBuilderInterface
1212
{
1313
/**
14-
* @param array $queryParams
15-
* @return string
14+
* {@inheritdoc}
15+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
1616
*/
1717
public function getUrl(array $queryParams = [])
1818
{

0 commit comments

Comments
 (0)