ENGCOM-8705: Bundle product: incorrect child item invoice_qty when dynamic price is set to false #31750

 - Merge Pull Request #31750 from engcom-Hotel/magento2:Bundle_product_incorrect_child_item_invoice_qty_when_dynamic_price_is_set_to_false_#30802
 - Merged commits:
   1. c9d0dc5
   2. 1542608
   3. f41c34a
   4. 06e5543

Author: magento-engcom-team

app/code/Magento/Sales/Model/Service/InvoiceService.php

@@ -194,7 +194,7 @@ private function prepareItemsQty(
     ): array {
         foreach ($order->getAllItems() as $orderItem) {
             if (isset($orderItemsQtyToInvoice[$orderItem->getId()])) {
-                if ($orderItem->isDummy() && $orderItem->getHasChildren()) {
+                if ($orderItem->getHasChildren()) {
                     $orderItemsQtyToInvoice = $this->setChildItemsQtyToInvoice($orderItem, $orderItemsQtyToInvoice);
                 }
             } else {

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/SaveTest.php

@@ -218,19 +218,21 @@ public function testPartialInvoiceWitConfigurableProduct(): void
     }
 
     /**
-     * Get order items qty invoiced
+     * @magentoDataFixture Magento/Sales/_files/order_with_bundle_dynamic_price_no.php
      *
-     * @param int $orderId
-     * @return array
+     * @return void
      */
-    private function getOrderItemsQtyInvoiced(int $orderId): array
+    public function testOrderItemsQtyInvoicedForBundleDynamicPriceFalse(): void
     {
-        $connection = $this->orderItemResource->getConnection();
-        $select = $connection->select()
-            ->from($this->orderItemResource->getMainTable(), OrderItemInterface::QTY_INVOICED)
-            ->where(OrderItemInterface::ORDER_ID . ' = ?', $orderId);
+        $order = $this->getOrder('100000001');
+        $entityId = $order->getEntityId();
 
-        return $connection->fetchCol($select);
+        $this->prepareRequest([], ['order_id' => $entityId]);
+        $this->dispatch('backend/sales/order_invoice/save');
+
+        $ordered = $this->getOrderItemsQtyOrdered((int)$entityId);
+        $invoiced = $this->getOrderItemsQtyInvoiced((int)$entityId);
+        $this->assertEquals($ordered, $invoiced);
     }
 
     /**
@@ -314,4 +316,36 @@ private function checkSuccess(
         );
         $this->assertSessionMessages($this->containsEqual((string)__($message)));
     }
+
+    /**
+     * Get order items qty invoiced
+     *
+     * @param int $orderId
+     * @return array
+     */
+    private function getOrderItemsQtyInvoiced(int $orderId): array
+    {
+        $connection = $this->orderItemResource->getConnection();
+        $select = $connection->select()
+            ->from($this->orderItemResource->getMainTable(), OrderItemInterface::QTY_INVOICED)
+            ->where(OrderItemInterface::ORDER_ID . ' = ?', $orderId);
+
+        return $connection->fetchCol($select);
+    }
+
+    /**
+     * Get order items qty ordered
+     *
+     * @param int $orderId
+     * @return array
+     */
+    private function getOrderItemsQtyOrdered(int $orderId): array
+    {
+        $connection = $this->orderItemResource->getConnection();
+        $select = $connection->select()
+            ->from($this->orderItemResource->getMainTable(), OrderItemInterface::QTY_ORDERED)
+            ->where(OrderItemInterface::ORDER_ID . ' = ?', $orderId);
+
+        return $connection->fetchCol($select);
+    }
 }

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_bundle_dynamic_price_no.php

@@ -0,0 +1,90 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Sales\Api\Data\OrderInterfaceFactory;
+use Magento\Sales\Api\Data\OrderItemInterface;
+use Magento\Sales\Api\OrderRepositoryInterface;
+use Magento\Sales\Model\Order;
+use Magento\Sales\Model\Order\Item;
+use Magento\TestFramework\ObjectManager;
+use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
+
+Resolver::getInstance()->requireDataFixture('Magento/Sales/_files/order.php');
+
+$objectManager = ObjectManager::getInstance();
+/** @var Order $order */
+$order = $objectManager->get(OrderInterfaceFactory::class)->create()->loadByIncrementId('100000001');
+
+$orderItems = [
+    [
+        OrderItemInterface::SKU => 'bundle_1',
+        OrderItemInterface::NAME => 'bundle_1',
+        OrderItemInterface::PRODUCT_ID => 2,
+        OrderItemInterface::BASE_PRICE => 100,
+        OrderItemInterface::ORDER_ID => $order->getId(),
+        OrderItemInterface::QTY_ORDERED => 2,
+        OrderItemInterface::PRICE => 100,
+        OrderItemInterface::ROW_TOTAL => 102,
+        OrderItemInterface::PRODUCT_TYPE => 'bundle',
+        'product_options' => [
+            'product_calculations' => 1,
+            'info_buyRequest' => [
+                'bundle_option' => [1 => 1],
+                'bundle_option_qty' => 1,
+            ]
+        ],
+        'children' => [
+            [
+                OrderItemInterface::SKU => 'bundle_simple_1',
+                OrderItemInterface::NAME => 'bundle_simple_1',
+                OrderItemInterface::PRODUCT_ID => 13,
+                OrderItemInterface::ORDER_ID => $order->getId(),
+                OrderItemInterface::QTY_ORDERED => 10,
+                OrderItemInterface::BASE_PRICE => 90,
+                OrderItemInterface::PRICE => 90,
+                OrderItemInterface::ROW_TOTAL => 92,
+                OrderItemInterface::PRODUCT_TYPE => 'simple',
+                'product_options' => [
+                    'bundle_selection_attributes' => '{"qty":5}',
+                ],
+            ],
+        ],
+    ],
+];
+
+if (!function_exists('saveOrderItems')) {
+    /**
+     * Save Order Items.
+     *
+     * @param array $orderItems
+     * @param Item|null $parentOrderItem [optional]
+     * @return void
+     */
+    function saveOrderItems(array $orderItems, Order $order, $parentOrderItem = null)
+    {
+        $objectManager = ObjectManager::getInstance();
+
+        foreach ($orderItems as $orderItemData) {
+            /** @var Item $orderItem */
+            $orderItem = $objectManager->create(Item::class);
+            if (null !== $parentOrderItem) {
+                $orderItemData['parent_item'] = $parentOrderItem;
+            }
+            $orderItem->setData($orderItemData);
+            $order->addItem($orderItem);
+
+            if (isset($orderItemData['children'])) {
+                saveOrderItems($orderItemData['children'], $order, $orderItem);
+            }
+        }
+    }
+}
+
+saveOrderItems($orderItems, $order);
+/** @var OrderRepositoryInterface $orderRepository */
+$orderRepository = $objectManager->get(OrderRepositoryInterface::class);
+$order = $orderRepository->save($order);

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_bundle_dynamic_price_no_rollback.php

@@ -0,0 +1,10 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
+
+Resolver::getInstance()->requireDataFixture('Magento/Sales/_files/order_rollback.php');