MAGETWO-66160: [GitHub][PR] Allows you to have 0 as a option #7701

vrann · vrann · commit b92c1c424907 · 2017-03-14T18:32:30.000-07:00
- Merge Pull Request #7701 from Corefix/magento2:patch-6
diff --git a/app/code/Magento/Swatches/Model/Plugin/EavAttribute.php b/app/code/Magento/Swatches/Model/Plugin/EavAttribute.php
@@ -446,7 +446,7 @@ protected function isOptionsValid(array $options, Attribute $attribute)
             if ($this->isOptionForDelete($attribute, $optionId)) {
                 continue;
             }
-            if (empty($option[0])) {
+            if (!isset($option[0]) || $option[0] === '') {
                 return false;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -446,7 +446,7 @@ protected function isOptionsValid(array $options, Attribute $attribute)`
`446`	`446`	`if ($this->isOptionForDelete($attribute, $optionId)) {`
`447`	`447`	`continue;`
`448`	`448`	`}`
`449`		`- if (empty($option[0])) {`
	`449`	`+ if (!isset($option[0]) \|\| $option[0] === '') {`
`450`	`450`	`return false;`
`451`	`451`	`}`
`452`	`452`	`}`