ACP2E-331: For products that do not have a category, the catalog price rule fails on condition, not in specific category.

Author: dhorytskyi

app/code/Magento/Catalog/Model/Api/SearchCriteria/CollectionProcessor/ConditionProcessor/ProductCategoryCondition.php

@@ -10,7 +10,6 @@
 use Magento\Framework\Api\SearchCriteria\CollectionProcessor\ConditionProcessor\CustomConditionInterface;
 use Magento\Catalog\Model\ResourceModel\Product\Collection;
 use Magento\Framework\Api\Filter;
-use Magento\Framework\Data\Collection\AbstractDb;
 use Magento\Framework\Exception\NoSuchEntityException as CategoryDoesNotExistException;
 
 /**
@@ -63,12 +62,12 @@ public function build(Filter $filter): string
             )->where(
                 $this->resourceConnection->getConnection()->prepareSqlCondition(
                     'cat.category_id',
-                    [$this->mapConditionType($filter->getConditionType()) => $this->getCategoryIds($filter)]
+                    ['in' => $this->getCategoryIds($filter)]
                 )
             );
 
         $selectCondition = [
-            'in' => $categorySelect
+            $this->mapConditionType($filter->getConditionType()) => $categorySelect
         ];
 
         return $this->resourceConnection->getConnection()
@@ -116,12 +115,7 @@ private function getCategoryIds(Filter $filter): array
      */
     private function mapConditionType(string $conditionType): string
     {
-        $conditionsMap = [
-            'eq' => 'in',
-            'neq' => 'nin',
-            'like' => 'in',
-            'nlike' => 'nin',
-        ];
-        return $conditionsMap[$conditionType] ?? $conditionType;
+        $ninConditions = ['nin', 'neq', 'nlike'];
+        return in_array($conditionType, $ninConditions, true) ? 'nin' : 'in';
     }
 }