Updated code and docs from code mess

Author: kschroeder

setup/src/Magento/Setup/Module/Di/Code/Reader/ClassesScanner.php

@@ -30,16 +30,18 @@ class ClassesScanner implements ClassesScannerInterface
 
     /**
      * @param array $excludePatterns
+     * @param string $generationDirectory
      */
-    public function __construct(array $excludePatterns = [], $generationDirectory = false)
+
+    public function __construct(array $excludePatterns = [], $generationDirectory = null)
     {
         $this->excludePatterns = $excludePatterns;
         $this->generationDirectory = $generationDirectory;
     }
 
     public function getGenerationDirectory()
     {
-        if ($this->generationDirectory === false) {
+        if ($this->generationDirectory === null) {
             $directoryList = ObjectManager::getInstance()->get(DirectoryList::class);
             /* @var $directoryList DirectoryList */
             $this->generationDirectory = $directoryList->getPath(DirectoryList::GENERATION);
@@ -61,7 +63,7 @@ public function addExcludePatterns(array $excludePatterns)
     /**
      * Determines if the path provided is in the var/generation folder
      *
-     * @param $path
+     * @param string $path
      * @return bool
      */
 

setup/src/Magento/Setup/Module/Di/Code/Reader/FileClassScanner.php

@@ -82,7 +82,7 @@ protected function extract()
 
         $this->tokens = token_get_all($this->getFileContents());
         foreach ($this->tokens as $index => $token) {
-            // Is either a literal brace or an interpolated brace
+            // Is either a literal brace or an interpolated brace with a variable
             if ($token == '{' || (is_array($token) && in_array($token[0], $allowedOpenBraces))) {
                 $braceLevel++;
             } else if ($token == '}') {
@@ -127,13 +127,13 @@ protected function extract()
                 $class = '';
             }
         }
-        return $classes;;
+        return $classes;
     }
 
     /**
      * Looks forward from the current index to determine if the namespace is nested in {} or terminated with ;
      *
-     * @param $index
+     * @param integer $index
      * @return bool
      */
 

setup/src/Magento/Setup/Test/Unit/Module/Di/Code/Reader/ClassesScannerTest.php

@@ -43,5 +43,4 @@ public function testIsGenerationNotesGenerationPath()
     {
         self::assertTrue($this->model->isGeneration($this->generation));
     }
-
 }

setup/src/Magento/Setup/Test/Unit/Module/Di/Code/Reader/FileClassScannerTest.php

@@ -120,7 +120,6 @@ public function test()
         self::assertContains('This\Is\My\Ns\ThisIsMyTest', $result);
     }
 
-
     public function testGetMultiClassNameAndMultiNamespace()
     {
         $scanner = $this->getMockBuilder(FileClassScanner::class)->disableOriginalConstructor()->setMethods([