ENGCOM-5153: Properly transliterate German Umlauts #22989

Author: p-bystritsky

lib/internal/Magento/Framework/Filter/Test/Unit/TranslitTest.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Framework\Filter\Test\Unit;
 
+/**
+ * Translit test.
+ */
 class TranslitTest extends \PHPUnit\Framework\TestCase
 {
     /**
@@ -45,8 +48,8 @@ public function filterDataProvider()
             ['привет мир', 'privet mir', 'privet mir', $isIconv],
             [
                 'Weiß, Goldmann, Göbel, Weiss, Göthe, Goethe und Götz',
-                'Weiss, Goldmann, Gobel, Weiss, Gothe, Goethe und Gotz',
-                'Weiss, Goldmann, Gobel, Weiss, Gothe, Goethe und Gotz',
+                'Weiss, Goldmann, Goebel, Weiss, Goethe, Goethe und Goetz',
+                'Weiss, Goldmann, Goebel, Weiss, Goethe, Goethe und Goetz',
                 $isIconv
             ],
             [

lib/internal/Magento/Framework/Filter/Test/Unit/TranslitUrlTest.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Framework\Filter\Test\Unit;
 
+/**
+ * Translit url test.
+ */
 class TranslitUrlTest extends \PHPUnit\Framework\TestCase
 {
     /**
@@ -45,8 +48,8 @@ public function filterDataProvider()
             ['привет мир', 'privet-mir', 'privet-mir', $isIconv],
             [
                 'Weiß, Goldmann, Göbel, Weiss, Göthe, Goethe und Götz',
-                'weiss-goldmann-gobel-weiss-gothe-goethe-und-gotz',
-                'weiss-goldmann-gobel-weiss-gothe-goethe-und-gotz',
+                'weiss-goldmann-goebel-weiss-goethe-goethe-und-goetz',
+                'weiss-goldmann-goebel-weiss-goethe-goethe-und-goetz',
                 $isIconv
             ],
             [

lib/internal/Magento/Framework/Filter/Translit.php

@@ -25,7 +25,7 @@ class Translit implements \Zend_Filter_Interface
         'À' => 'a',
         'Á' => 'a',
         'Â' => 'a',
-        'Ä' => 'a',
+        'Ä' => 'ae',
         'Å' => 'a',
         'Æ' => 'ae',
         'Ç' => 'c',
@@ -40,18 +40,18 @@ class Translit implements \Zend_Filter_Interface
         'Ó' => 'o',
         'Ô' => 'o',
         'Õ' => 'o',
-        'Ö' => 'o',
+        'Ö' => 'oe',
         'Ø' => 'o',
         'Ù' => 'u',
         'Ú' => 'u',
         'Û' => 'u',
-        'Ü' => 'u',
+        'Ü' => 'ue',
         'Ý' => 'y',
         'ß' => 'ss',
         'à' => 'a',
         'á' => 'a',
         'â' => 'a',
-        'ä' => 'a',
+        'ä' => 'ae',
         'å' => 'a',
         'æ' => 'ae',
         'ç' => 'c',
@@ -67,12 +67,12 @@ class Translit implements \Zend_Filter_Interface
         'ó' => 'o',
         'ô' => 'o',
         'õ' => 'o',
-        'ö' => 'o',
+        'ö' => 'oe',
         'ø' => 'o',
         'ù' => 'u',
         'ú' => 'u',
         'û' => 'u',
-        'ü' => 'u',
+        'ü' => 'ue',
         'ý' => 'y',
         'þ' => 'p',
         'ÿ' => 'y',