MAGETWO-30415: [GITHUB] \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code #682

Yu Tang · Yu Tang · commit b7cde0221cb8 · 2015-01-09T15:10:37.000-06:00
- Change parameter name in implementation class to be consistent with interface
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -59,10 +59,10 @@ public function convert($amount, $scope = null, $currency = null)
     /**
      * {@inheritdoc}
      */
-    public function convertAndRound($amount, $store = null, $currency = null, $precision = self::DEFAULT_PRECISION)
+    public function convertAndRound($amount, $scope = null, $currency = null, $precision = self::DEFAULT_PRECISION)
     {
-        $currentCurrency = $this->getCurrency($store, $currency);
-        $convertedValue = $this->getStore($store)->getBaseCurrency()->convert($amount, $currentCurrency);
+        $currentCurrency = $this->getCurrency($scope, $currency);
+        $convertedValue = $this->getStore($scope)->getBaseCurrency()->convert($amount, $currentCurrency);
         return round($convertedValue, $precision);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,10 @@ public function convert($amount, $scope = null, $currency = null)`
`59`	`59`	`/**`
`60`	`60`	`* {@inheritdoc}`
`61`	`61`	`*/`
`62`		`- public function convertAndRound($amount, $store = null, $currency = null, $precision = self::DEFAULT_PRECISION)`
	`62`	`+ public function convertAndRound($amount, $scope = null, $currency = null, $precision = self::DEFAULT_PRECISION)`
`63`	`63`	`{`
`64`		`- $currentCurrency = $this->getCurrency($store, $currency);`
`65`		`- $convertedValue = $this->getStore($store)->getBaseCurrency()->convert($amount, $currentCurrency);`
	`64`	`+ $currentCurrency = $this->getCurrency($scope, $currency);`
	`65`	`+ $convertedValue = $this->getStore($scope)->getBaseCurrency()->convert($amount, $currentCurrency);`
`66`	`66`	`return round($convertedValue, $precision);`
`67`	`67`	`}`
`68`	`68`