Skip to content

Commit b7b8306

Browse files
author
Dale Sikkema
committed
MAGETWO-34447: Pull Request for Sprint 46 stories
- update resource namespaces and module dependencies
1 parent 33e980f commit b7b8306

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

app/code/Magento/Backend/etc/adminhtml/system.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
<section id="design" translate="label" type="text" sortOrder="30" showInDefault="1" showInWebsite="1" showInStore="1">
100100
<label>Design</label>
101101
<tab>general</tab>
102-
<resource>Magento_Backend::config_design</resource>
102+
<resource>Magento_Config::config_design</resource>
103103
<group id="theme" translate="label" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
104104
<label>Design Theme</label>
105105
<field id="theme_id" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
@@ -236,7 +236,7 @@
236236
<section id="general" translate="label" type="text" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
237237
<label>General</label>
238238
<tab>general</tab>
239-
<resource>Magento_Backend::config_general</resource>
239+
<resource>Magento_Config::config_general</resource>
240240
<group id="country" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
241241
<label>Country Options</label>
242242
<field id="allow" translate="label" type="multiselect" sortOrder="2" showInDefault="1" showInWebsite="1" showInStore="1">
@@ -321,7 +321,7 @@
321321
<class>separator-top</class>
322322
<label>System</label>
323323
<tab>advanced</tab>
324-
<resource>Magento_Backend::config_system</resource>
324+
<resource>Magento_Config::config_system</resource>
325325
<group id="smtp" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
326326
<label>Mail Sending Settings</label>
327327
<field id="disable" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
@@ -375,7 +375,7 @@
375375
<section id="admin" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="0">
376376
<label>Admin</label>
377377
<tab>advanced</tab>
378-
<resource>Magento_Backend::config_admin</resource>
378+
<resource>Magento_Config::config_admin</resource>
379379
<group id="emails" translate="label" type="text" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">
380380
<label>Admin User Emails</label>
381381
<field id="forgot_email_template" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0">

app/code/Magento/Config/Controller/Adminhtml/System/AbstractConfig.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
6060
protected function _isAllowed()
6161
{
6262
$sectionId = $this->_request->getParam('section');
63-
return $this->_authorization->isAllowed('Magento_Backend::config')
63+
return $this->_authorization->isAllowed('Magento_Config::config')
6464
|| $this->_configStructure->getElement($sectionId)->isAllowed();
6565
}
6666

app/code/Magento/Payment/composer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"php": "~5.5.0|~5.6.0",
66
"magento/module-config": "0.42.0-beta9",
77
"magento/module-store": "0.42.0-beta9",
8-
"magento/module-core": "0.42.0-beta9",
98
"magento/module-sales": "0.42.0-beta9",
109
"magento/module-centinel": "0.42.0-beta9",
1110
"magento/module-checkout": "0.42.0-beta9",

app/code/Magento/Payment/etc/module.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
99
<module name="Magento_Payment" schema_version="2.0.0">
1010
<sequence>
11-
<module name="Magento_Core"/>
1211
<module name="Magento_Store"/>
1312
<module name="Magento_Catalog"/>
1413
</sequence>

dev/tests/unit/testsuite/Magento/Backend/Model/Menu/ItemTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase
5454
'id' => 'item',
5555
'title' => 'Item Title',
5656
'action' => '/system/config',
57-
'resource' => 'Magento_Backend::config',
57+
'resource' => 'Magento_Config::config',
5858
'dependsOnModule' => 'Magento_Backend',
5959
'dependsOnConfig' => 'system/config/isEnabled',
6060
'tooltip' => 'Item tooltip',
@@ -192,7 +192,7 @@ public function testIsAllowedReturnsTrueIfResourceIsAvailable()
192192
)->method(
193193
'isAllowed'
194194
)->with(
195-
'Magento_Backend::config'
195+
'Magento_Config::config'
196196
)->will(
197197
$this->returnValue(true)
198198
);
@@ -206,7 +206,7 @@ public function testIsAllowedReturnsFalseIfResourceIsNotAvailable()
206206
)->method(
207207
'isAllowed'
208208
)->with(
209-
'Magento_Backend::config'
209+
'Magento_Config::config'
210210
)->will(
211211
$this->throwException(new \Magento\Framework\Exception())
212212
);

0 commit comments

Comments
 (0)