Skip to content

Commit b77e66d

Browse files
committed
#27499: Code review changes
1 parent 3784f92 commit b77e66d

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

app/code/Magento/MediaGallery/Model/Asset/Command/GetByPath.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,22 @@ public function __construct(
5959
/**
6060
* Return media asset asset list
6161
*
62-
* @param string $mediaFilePath
62+
* @param string $path
6363
*
6464
* @return AssetInterface
6565
* @throws IntegrationException
6666
*/
67-
public function execute(string $mediaFilePath): AssetInterface
67+
public function execute(string $path): AssetInterface
6868
{
6969
try {
7070
$connection = $this->resourceConnection->getConnection();
7171
$select = $connection->select()
7272
->from($this->resourceConnection->getTableName(self::TABLE_MEDIA_GALLERY_ASSET))
73-
->where(self::MEDIA_GALLERY_ASSET_PATH . ' = ?', $mediaFilePath);
73+
->where(self::MEDIA_GALLERY_ASSET_PATH . ' = ?', $path);
7474
$data = $connection->query($select)->fetch();
7575

7676
if (empty($data)) {
77-
$message = __('There is no such media asset with path "%1"', $mediaFilePath);
77+
$message = __('There is no such media asset with path "%1"', $path);
7878
throw new NoSuchEntityException($message);
7979
}
8080

app/code/Magento/MediaGalleryApi/Api/Data/AssetInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function getPath(): string;
3939
public function getTitle(): ?string;
4040

4141
/**
42-
* Get source of the file
42+
* Get the name of the channel/stock/integration file was retrieved from. null if not identified.
4343
*
4444
* @return string|null
4545
*/

app/code/Magento/MediaGalleryApi/Model/Asset/Command/GetByPathInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ interface GetByPathInterface
1717
/**
1818
* Get media asset list
1919
*
20-
* @param string $mediaFilePath
20+
* @param string $path
2121
* @return \Magento\MediaGalleryApi\Api\Data\AssetInterface
2222
*/
23-
public function execute(string $mediaFilePath): \Magento\MediaGalleryApi\Api\Data\AssetInterface;
23+
public function execute(string $path): \Magento\MediaGalleryApi\Api\Data\AssetInterface;
2424
}

app/code/Magento/MediaGalleryApi/Model/Asset/Command/SaveInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
interface SaveInterface
1818
{
1919
/**
20-
* Save media asset
20+
* Save media asset and return the media asset id
2121
*
2222
* @param \Magento\MediaGalleryApi\Api\Data\AssetInterface $mediaAsset
2323
* @return int

0 commit comments

Comments
 (0)