Skip to content

Commit b76a01a

Browse files
committed
MAGETWO-60034: Cannot ship remaining items in an order for several of one product if credit memo is made for some
- fix functional tests
1 parent e1b0217 commit b76a01a

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertOrderCancelMassActionFailMessage.php renamed to dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertOrderCancelMassActionPartialFailMessage.php

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,20 @@
1010
use Magento\Mtf\Constraint\AbstractConstraint;
1111

1212
/**
13-
* Class AssertOrderCancelMassActionFailMessage
13+
* Class AssertOrderCancelAndSuccessMassActionFailMessage
1414
* Assert cancel fail message is displayed on order index page
1515
*/
16-
class AssertOrderCancelMassActionFailMessage extends AbstractConstraint
16+
class AssertOrderCancelMassActionPartialFailMessage extends AbstractConstraint
1717
{
18+
/**
19+
* Message displayed after cancel order from archive
20+
*/
21+
const SUCCESS_MESSAGE = 'We canceled 1 order(s).';
22+
1823
/**
1924
* Text value to be checked
2025
*/
21-
const FAIL_CANCEL_MESSAGE = 'You cannot cancel the order(s).';
26+
const FAIL_CANCEL_MESSAGE = '1 order(s) cannot be canceled.';
2227

2328
/**
2429
* Assert cancel fail message is displayed on order index page
@@ -32,6 +37,10 @@ public function processAssert(OrderIndex $orderIndex)
3237
self::FAIL_CANCEL_MESSAGE,
3338
$orderIndex->getMessagesBlock()->getErrorMessage()
3439
);
40+
\PHPUnit\Framework\Assert::assertEquals(
41+
self::SUCCESS_MESSAGE,
42+
$orderIndex->getMessagesBlock()->getSuccessMessage()
43+
);
3544
}
3645

3746
/**
@@ -41,6 +50,6 @@ public function processAssert(OrderIndex $orderIndex)
4150
*/
4251
public function toString()
4352
{
44-
return 'Cancel fail message is displayed on order index page.';
53+
return 'Cancel and success fail message is displayed on order index page.';
4554
}
4655
}

dev/tests/functional/tests/app/Magento/Sales/Test/TestCase/MassOrdersUpdateTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818
<constraint name="Magento\Sales\Test\Constraint\AssertOrdersInOrdersGrid" />
1919
</variation>
2020
<variation name="MassOrdersUpdateTestVariation2">
21-
<data name="description" xsi:type="string">try to cancel orders in status Complete, Closed</data>
21+
<data name="description" xsi:type="string">try to cancel orders in status Complete, Canceled</data>
2222
<data name="steps" xsi:type="string">invoice, shipment|invoice, credit memo</data>
2323
<data name="action" xsi:type="string">Cancel</data>
2424
<data name="ordersCount" xsi:type="string">2</data>
25-
<data name="resultStatuses" xsi:type="string">Complete,Processing</data>
26-
<constraint name="Magento\Sales\Test\Constraint\AssertOrderCancelMassActionFailMessage" />
25+
<data name="resultStatuses" xsi:type="string">Complete,Canceled</data>
26+
<constraint name="Magento\Sales\Test\Constraint\AssertOrderCancelMassActionPartialFailMessage" />
2727
<constraint name="Magento\Sales\Test\Constraint\AssertOrdersInOrdersGrid" />
2828
</variation>
2929
<variation name="MassOrdersUpdateTestVariation3">
3030
<data name="description" xsi:type="string">try to cancel orders in status Pending, Closed</data>
3131
<data name="steps" xsi:type="string">invoice|invoice, credit memo</data>
3232
<data name="action" xsi:type="string">Cancel</data>
3333
<data name="ordersCount" xsi:type="string">2</data>
34-
<data name="resultStatuses" xsi:type="string">Processing,Closed</data>
35-
<constraint name="Magento\Sales\Test\Constraint\AssertOrderCancelMassActionFailMessage" />
34+
<data name="resultStatuses" xsi:type="string">Processing,Canceled</data>
35+
<constraint name="Magento\Sales\Test\Constraint\AssertOrderCancelMassActionPartialFailMessage" />
3636
<constraint name="Magento\Sales\Test\Constraint\AssertOrdersInOrdersGrid" />
3737
</variation>
3838
<variation name="MassOrdersUpdateTestVariation4">
@@ -55,7 +55,7 @@
5555
<constraint name="Magento\Sales\Test\Constraint\AssertOrdersInOrdersGrid" />
5656
</variation>
5757
<variation name="MassOrdersUpdateTestVariation6">
58-
<data name="description" xsi:type="string">Release order in statuse On Hold</data>
58+
<data name="description" xsi:type="string">Release order in status On Hold</data>
5959
<data name="steps" xsi:type="string">on hold</data>
6060
<data name="action" xsi:type="string">Unhold</data>
6161
<data name="ordersCount" xsi:type="string">1</data>

0 commit comments

Comments
 (0)