MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found #7780

Oleksii Korshenko · Oleksii Korshenko · commit b71d5c9cd7de · 2017-06-09T16:03:37.000-07:00
- Merge Pull Request #7780 from vaimo/magento2:fix/throw-exception-if-compilation-fails
diff --git a/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php b/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php
@@ -80,11 +80,15 @@ public function add($type, $key, $message = '')
      * Write entries
      *
      * @return void
+     * @throws \Magento\Framework\Validator\Exception
      */
     public function report()
     {
         $this->_successWriter->write($this->_successEntries);
         $this->_errorWriter->write($this->_errorEntries);
+        if (count($this->_errorEntries) > 0) {
+            throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -80,11 +80,15 @@ public function add($type, $key, $message = '')`
`80`	`80`	`* Write entries`
`81`	`81`	`*`
`82`	`82`	`* @return void`
	`83`	`+ * @throws \Magento\Framework\Validator\Exception`
`83`	`84`	`*/`
`84`	`85`	`public function report()`
`85`	`86`	`{`
`86`	`87`	`$this->_successWriter->write($this->_successEntries);`
`87`	`88`	`$this->_errorWriter->write($this->_errorEntries);`
	`89`	`+ if (count($this->_errorEntries) > 0) {`
	`90`	`+ throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));`
	`91`	`+ }`
`88`	`92`	`}`
`89`	`93`
`90`	`94`	`/**`