Skip to content

Commit b648841

Browse files
committed
CE#34569: CR improvements
1 parent bb764a8 commit b648841

File tree

2 files changed

+11
-17
lines changed
  • app/code/Magento
    • CatalogImportExport/Model/Import/Product
    • Catalog/Model/Product/Option/Type

2 files changed

+11
-17
lines changed

app/code/Magento/Catalog/Model/Product/Option/Type/Date.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,7 @@ public function prepareOptionValueForRequest($optionValue)
306306
try {
307307
$value = $this->serializer->unserialize($infoBuyRequest->getValue());
308308

309-
if (is_array($value)
310-
&& isset($value['options'])
311-
&& isset($value['options'][$this->getOption()->getId()])
312-
) {
309+
if (is_array($value) && isset($value['options'][$this->getOption()->getId()])) {
313310
return $value['options'][$this->getOption()->getId()];
314311
} else {
315312
return ['date_internal' => $optionValue];

app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2093,21 +2093,18 @@ protected function _parseCustomOptions($rowData)
20932093
$optionValueParams = explode($this->_productEntity->getMultipleValueSeparator(), $optionValue);
20942094
foreach ($optionValueParams as $nameAndValue) {
20952095
$nameAndValue = explode('=', $nameAndValue);
2096-
// @phpstan-ignore-next-line
2097-
if (!empty($nameAndValue)) {
2098-
$value = isset($nameAndValue[1]) ? $nameAndValue[1] : '';
2099-
$value = trim($value);
2100-
$fieldName = trim($nameAndValue[0]);
2101-
if ($value && ($fieldName == 'name')) {
2102-
if ($name != $value) {
2103-
$name = $value;
2104-
$k = 0;
2105-
}
2106-
}
2107-
if ($name) {
2108-
$options[$name][$k][$fieldName] = $value;
2096+
$value = isset($nameAndValue[1]) ? $nameAndValue[1] : '';
2097+
$value = trim($value);
2098+
$fieldName = trim($nameAndValue[0]);
2099+
if ($value && ($fieldName === 'name')) {
2100+
if ($name != $value) {
2101+
$name = $value;
2102+
$k = 0;
21092103
}
21102104
}
2105+
if ($name) {
2106+
$options[$name][$k][$fieldName] = $value;
2107+
}
21112108
}
21122109
if (isset($rowData[Product::COL_STORE_VIEW_CODE])) {
21132110
$options[$name][$k][self::COLUMN_STORE] = $rowData[Product::COL_STORE_VIEW_CODE];

0 commit comments

Comments
 (0)