ACP2E-63: Queries with bad performance

Author: valdislav

app/code/Magento/Sales/Model/ResourceModel/Provider/Query/IdListBuilder.php

@@ -32,6 +32,8 @@ class IdListBuilder
     private $connection;
 
     /**
+     * IdListBuilder. Builds query for getting updated id list.
+     *
      * @param ResourceConnection $resourceConnection
      */
     public function __construct(ResourceConnection $resourceConnection)
@@ -40,6 +42,8 @@ public function __construct(ResourceConnection $resourceConnection)
     }
 
     /**
+     * Adding additional grid table where entities may already exist.
+     *
      * @param string $table
      * @return $this
      */
@@ -82,9 +86,11 @@ private function getLastUpdatedAtValue(string $gridTableName): string
     }
 
     /**
+     * @param string $mainTableName
+     * @param string $gridTableName
      * @return Select
      */
-    public function build($mainTableName, $gridTableName): Select
+    public function build(string $mainTableName, string $gridTableName): Select
     {
         $select = $this->getConnection()->select()
             ->from($mainTableName, [$mainTableName . '.entity_id']);

app/code/Magento/Sales/Model/ResourceModel/Provider/UpdatedIdListProvider.php

@@ -5,7 +5,6 @@
  */
 namespace Magento\Sales\Model\ResourceModel\Provider;
 
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\Sales\Model\ResourceModel\Provider\Query\IdListBuilder;
@@ -40,9 +39,6 @@ public function __construct(
         IdListBuilder $idListQueryBuilder = null
     ) {
         $this->resourceConnection = $resourceConnection;
-        if (!$idListQueryBuilder) {
-            $idListQueryBuilder = ObjectManager::getInstance()->get(IdListBuilder::class);
-        }
         $this->idListQueryBuilder = $idListQueryBuilder;
     }