Skip to content

Commit b611779

Browse files
committed
MC-18013: Ensure that accordion anchor is visible on viewport once clicked
1 parent 4c7f71d commit b611779

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

app/code/Magento/Review/Test/Mftf/ActionGroup/AdminOpenPendingReviewsPageActionGroup.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="AdminOpenPendingReviewsPageActionGroup">
1111
<amOnPage url="{{AdminPendingReviewsPage.url}}" stepKey="openReviewsPageActionGroup"/>
12-
<waitForPageLoad stepKey="waitForReviewsPageLoad"/>
1312
</actionGroup>
1413
</actionGroups>

app/code/Magento/Review/Test/Mftf/ActionGroup/StorefrontAddProductReviewActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<argument name="review" type="entity" defaultValue="SimpleProductReview"/>
1313
</arguments>
1414
<click selector="{{StorefrontProductReviewsSection.reviewsTab}}" stepKey="openReviewTab"/>
15-
<waitForPageLoad stepKey="waitForTabOpening"/>
15+
<waitForPageLoad time="30" stepKey="waitForTabOpening"/>
1616
<fillField selector="{{StorefrontReviewFormSection.nicknameField}}" userInput="{{review.nickname}}" stepKey="fillNicknameField"/>
1717
<fillField selector="{{StorefrontReviewFormSection.summaryField}}" userInput="{{review.title}}" stepKey="fillSummaryField"/>
1818
<fillField selector="{{StorefrontReviewFormSection.reviewField}}" userInput="{{review.detail}}" stepKey="fillReviewField"/>

app/code/Magento/Review/Test/Mftf/Section/AdminReviewGridSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
<element name="nicknameColumnFilter" type="input" selector="#reviwGrid_filter_nickname"/>
1313
<element name="massActions" type="button" selector="#reviwGrid_massaction-mass-select"/>
1414
<element name="massActionsSelect" type="button" selector="#reviwGrid_massaction-select"/>
15-
<element name="submit" type="button" selector=".admin__grid-massaction-form .action-default.scalable"/>
15+
<element name="submit" type="button" timeout="30" selector="#reviwGrid_massaction button[title='Submit']"/>
1616
</section>
1717
</sections>

app/code/Magento/Review/Test/Mftf/Section/StorefrontReviewFormSection.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="StorefrontReviewFormSection">
12-
<element name="nicknameField" type="text" selector="#nickname_field"/>
13-
<element name="summaryField" type="text" selector="#summary_field"/>
14-
<element name="reviewField" type="textarea" selector="#review_field"/>
15-
<element name="submitReview" type="button" timeout="30" selector=".submit"/>
12+
<element name="nicknameField" type="text" selector="#review-form [name='nickname']"/>
13+
<element name="summaryField" type="text" selector="#review-form [name='title']"/>
14+
<element name="reviewField" type="textarea" selector="#review-form [name='detail']"/>
15+
<element name="submitReview" type="button" timeout="30" selector="#review-form button[type=submit]"/>
1616
</section>
1717
</sections>

app/code/Magento/Review/Test/Mftf/Test/StorefrontEnsureThatAccordionAnchorIsVisibleOnViewportOnceClickedTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,14 @@
6262
<deleteData createDataKey="createFourthAttribute" stepKey="deleteFourthAttribute"/>
6363
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
6464

65+
<!--Logout from customer account-->
66+
<actionGroup ref="CustomerLogoutStorefrontActionGroup" stepKey="logoutCustomer"/>
6567
<!-- Delete customer -->
6668
<actionGroup ref="AdminDeleteCustomerActionGroup" stepKey="deleteCustomer">
6769
<argument name="customerEmail" value="CustomerEntityOne.email"/>
6870
</actionGroup>
6971
<actionGroup ref="AdminClearCustomersFiltersActionGroup" stepKey="clearCustomersFilters"/>
72+
<actionGroup ref="logout" stepKey="logOut"/>
7073
</after>
7174

7275
<!-- Edit the product and set those attributes values -->

0 commit comments

Comments
 (0)