Skip to content

Commit b5a80fa

Browse files
author
Dmytro Aponasenko
committed
MTA-1994: Analyse functional test failures - Sprint 10
1 parent bab0327 commit b5a80fa

File tree

3 files changed

+30
-31
lines changed

3 files changed

+30
-31
lines changed

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Order/Create/Items.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,30 @@
1111
use Magento\Mtf\Client\Locator;
1212

1313
/**
14-
* Class Items
15-
* Adminhtml sales order create items block
14+
* Adminhtml sales order create items block.
1615
*/
1716
class Items extends Block
1817
{
1918
/**
20-
* 'Add Products' button
19+
* 'Add Products' button.
2120
*
2221
* @var string
2322
*/
2423
protected $addProducts = "//button[span='Add Products']";
2524

2625
/**
27-
* Item product
26+
* Item product.
2827
*
2928
* @var string
3029
*/
3130
protected $itemProduct = '//tr[td//*[normalize-space(text())="%s"]]';
3231

3332
/**
34-
* Product names
33+
* Product names.
3534
*
3635
* @var string
3736
*/
38-
protected $productNames = '//td[@class="col-product"]//span';
37+
protected $productNames = '//td[@class="col-product"]/span';
3938

4039
/**
4140
* Selector for template block.
@@ -45,7 +44,7 @@ class Items extends Block
4544
protected $template = './ancestor::body';
4645

4746
/**
48-
* Click 'Add Products' button
47+
* Click 'Add Products' button.
4948
*
5049
* @return void
5150
*/
@@ -63,7 +62,7 @@ function () use ($element, $selector) {
6362
}
6463

6564
/**
66-
* Get item product block
65+
* Get item product block.
6766
*
6867
* @param string $name
6968
* @return \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items\ItemProduct

dev/tests/functional/tests/app/Magento/SalesRule/Test/Block/Adminhtml/Promo/Quote/Edit/Tab/Labels.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function fillFormTab(array $fields, SimpleElement $element = null)
4545
* @param SimpleElement|null $element
4646
* @return array
4747
*
48-
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
48+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
4949
*/
5050
public function getDataFormTab($fields = null, SimpleElement $element = null)
5151
{

dev/tests/functional/tests/app/Magento/Wishlist/Test/TestCase/ConfigureProductInCustomerWishlistOnBackendTest.xml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@
66
*/
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
9-
<testCase name="Magento\Wishlist\Test\TestCase\ConfigureProductInCustomerWishlistOnBackendTest">
10-
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation1" firstConstraint="Magento\Wishlist\Test\Constraint\AssertProductInCustomerWishlistOnBackendGrid" method="test">
11-
<data name="product" xsi:type="string">catalogProductSimple::with_two_custom_option</data>
12-
<constraint name="Magento\Wishlist\Test\Constraint\AssertProductInCustomerWishlistOnBackendGrid"/>
13-
</variation>
14-
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation2" firstConstraint="Magento\ConfigurableProduct\Test\Constraint\AssertConfigurableProductInCustomerWishlistOnBackendGrid" method="test">
15-
<data name="product" xsi:type="string">configurableProduct::default</data>
16-
<constraint name="Magento\ConfigurableProduct\Test\Constraint\AssertConfigurableProductInCustomerWishlistOnBackendGrid"/>
17-
</variation>
18-
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation3" firstConstraint="Magento\Bundle\Test\Constraint\AssertBundleProductInCustomerWishlistOnBackendGrid" method="test">
19-
<data name="product" xsi:type="string">bundleProduct::bundle_dynamic_product</data>
20-
<constraint name="Magento\Bundle\Test\Constraint\AssertBundleProductInCustomerWishlistOnBackendGrid"/>
21-
</variation>
22-
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation4" firstConstraint="Magento\Downloadable\Test\Constraint\AssertDownloadableProductInCustomerWishlistOnBackendGrid" method="test">
23-
<data name="product" xsi:type="string">downloadableProduct::with_two_separately_links</data>
24-
<constraint name="Magento\Downloadable\Test\Constraint\AssertDownloadableProductInCustomerWishlistOnBackendGrid"/>
25-
</variation>
26-
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation5" firstConstraint="Magento\GroupedProduct\Test\Constraint\AssertGroupedProductInCustomerWishlistOnBackendGrid" method="test">
27-
<data name="product" xsi:type="string">groupedProduct::three_simple_products</data>
28-
<constraint name="Magento\GroupedProduct\Test\Constraint\AssertGroupedProductInCustomerWishlistOnBackendGrid"/>
29-
</variation>
30-
</testCase>
9+
<testCase name="Magento\Wishlist\Test\TestCase\ConfigureProductInCustomerWishlistOnBackendTest">
10+
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation1">
11+
<data name="product" xsi:type="string">catalogProductSimple::with_two_custom_option</data>
12+
<constraint name="Magento\Wishlist\Test\Constraint\AssertProductInCustomerWishlistOnBackendGrid" />
13+
</variation>
14+
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation2">
15+
<data name="product" xsi:type="string">configurableProduct::default</data>
16+
<constraint name="Magento\ConfigurableProduct\Test\Constraint\AssertConfigurableProductInCustomerWishlistOnBackendGrid" />
17+
</variation>
18+
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation3">
19+
<data name="product" xsi:type="string">bundleProduct::bundle_dynamic_product</data>
20+
<constraint name="Magento\Bundle\Test\Constraint\AssertBundleProductInCustomerWishlistOnBackendGrid" />
21+
</variation>
22+
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation4">
23+
<data name="product" xsi:type="string">downloadableProduct::with_two_separately_links</data>
24+
<constraint name="Magento\Downloadable\Test\Constraint\AssertDownloadableProductInCustomerWishlistOnBackendGrid" />
25+
</variation>
26+
<variation name="ConfigureProductInCustomerWishlistOnBackendTestVariation5">
27+
<data name="product" xsi:type="string">groupedProduct::three_simple_products</data>
28+
<constraint name="Magento\GroupedProduct\Test\Constraint\AssertGroupedProductInCustomerWishlistOnBackendGrid" />
29+
</variation>
30+
</testCase>
3131
</config>

0 commit comments

Comments
 (0)