MAGETWO-51566: Magento version is not updated after code update

 - make ComposerFactory a required parameter for ComposerInformation

Author: dsikkema-magento

dev/tests/integration/testsuite/Magento/Setup/Model/UpdatePackagesCacheTest.php

@@ -6,6 +6,7 @@
 
 namespace Magento\Setup\Model;
 
+use Magento\Framework\Composer\ComposerFactory;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Framework\Composer\ComposerJsonFinder;
 use Magento\Framework\Composer\MagentoComposerApplicationFactory;
@@ -66,9 +67,9 @@ private function setupDirectory($composerDir)
         $this->composerInformation = $this->objectManager->create(
             'Magento\Framework\Composer\ComposerInformation',
             [
-                'applicationFactory' => new MagentoComposerApplicationFactory(
-                    $this->composerJsonFinder,
-                    $this->directoryList
+                'composerFactory' => new ComposerFactory(
+                    $this->directoryList,
+                    $this->composerJsonFinder
                 )
             ]
         );

lib/internal/Magento/Framework/App/ProductMetadata.php

@@ -121,7 +121,7 @@ private function getComposerInformation()
         if (!$this->composerInformation) {
             $directoryList              = new DirectoryList(BP);
             $composerFactory            = new ComposerFactory($directoryList, $this->composerJsonFinder);
-            $this->composerInformation  = new ComposerInformation(null, $composerFactory);
+            $this->composerInformation  = new ComposerInformation($composerFactory);
         }
         return $this->composerInformation;
     }

lib/internal/Magento/Framework/Composer/ComposerInformation.php

@@ -3,13 +3,10 @@
  * Copyright © 2016 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 namespace Magento\Framework\Composer;
 
-use Composer\IO\BufferIO;
 use Composer\Package\Link;
 use Composer\Package\CompletePackageInterface;
-use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\App\ObjectManager;
 
 /**
@@ -92,15 +89,12 @@ class ComposerInformation
     private $composerFactory;
 
     /**
-     * @param MagentoComposerApplicationFactory $applicationFactory
      * @param ComposerFactory $composerFactory
      *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function __construct(
-        MagentoComposerApplicationFactory $applicationFactory = null,
-        \Magento\Framework\Composer\ComposerFactory $composerFactory = null
-    ) {
+    public function __construct(ComposerFactory $composerFactory)
+    {
         $this->composerFactory = $composerFactory;
     }