Skip to content

Commit b4bf561

Browse files
committed
Merge branch 'MAGETWO-34564-JS-error-if-expand-modules-list' into PR_Branch
2 parents 8dd4940 + 98f829d commit b4bf561

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

setup/pub/angular-sanitize/angular-sanitize.min.js

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

setup/pub/magento/setup/customize-your-store.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44
*/
55

66
'use strict';
7-
angular.module('customize-your-store', ['ngStorage'])
7+
angular.module('customize-your-store', ['ngStorage', 'ngSanitize'])
88
.controller('customizeYourStoreController', ['$scope', '$localStorage' , '$state', '$http', '$sce', function ($scope, $localStorage, $state, $http, $sce) {
99
$scope.store = {
1010
timezone: 'America/Los_Angeles',
1111
currency: 'USD',
1212
language: 'en_US',
1313
useSampleData: false,
1414
loadedAllModules: false,
15+
showModulesControl: false,
1516
selectAll: true,
1617
allModules: [],
1718
errorFlag : false,
@@ -51,6 +52,7 @@ angular.module('customize-your-store', ['ngStorage'])
5152
if (!$scope.store.loadedAllModules) {
5253
$http.get('index.php/modules').success(function (data) {
5354
$state.loadedModules = data;
55+
$scope.store.showModulesControl = true;
5456
if (data.error) {
5557
$scope.updateOnExpand($scope.store.advanced);
5658
$scope.store.errorMessage = $sce.trustAsHtml(data.error);

setup/view/layout/layout.phtml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
->appendFile('pub/angular-ng-storage/angular-ng-storage.min.js')
2323
->appendFile('pub/angular-ui-router/angular-ui-router.min.js')
2424
->appendFile('pub/angular-ui-bootstrap/angular-ui-bootstrap.min.js')
25+
->appendFile('pub/angular-sanitize/angular-sanitize.min.js')
2526
->appendFile('pub/magento/setup/app.js')
2627
->appendFile('pub/magento/setup/main.js')
2728
->appendFile('pub/magento/setup/landing.js')

setup/view/magento/setup/customize-your-store.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
</div>
119119
</fieldset>
120120

121-
<fieldset class="form-fieldset customize-your-store-advanced">
121+
<fieldset class="form-fieldset customize-your-store-advanced" ng-show="store.showModulesControl">
122122
<legend
123123
class="form-legend-expand"
124124
ng-click="updateOnExpand(store.advanced)"

0 commit comments

Comments
 (0)