Skip to content

Commit b46aba5

Browse files
MAGETWO-51185: Product image cannot be loaded from product page if minification enabled
1 parent 47d8234 commit b46aba5

File tree

1 file changed

+79
-0
lines changed
  • lib/internal/Magento/Framework/View/Test/Unit/Design/FileResolution/Fallback/Resolver

1 file changed

+79
-0
lines changed

lib/internal/Magento/Framework/View/Test/Unit/Design/FileResolution/Fallback/Resolver/MinificationTest.php

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,83 @@ public function resolveDataProvider()
9999
[false, 'file.min.css', 'file.min.css', false, false, 'found.css']
100100
];
101101
}
102+
103+
104+
public function testResolveJs()
105+
{
106+
$this->resolverMock
107+
->expects($this->once())
108+
->method('resolve')
109+
->willReturn('/var/test.min.js');
110+
$this->assetMinificationMock->expects($this->once())
111+
->method('isMinifiedFilename')
112+
->willReturn(true);
113+
114+
$this->assertEquals('/var/test.min.js', $this->minification->resolve('', 'test.min.js'));
115+
}
116+
117+
public function testResolveJsWithDisabledMinification()
118+
{
119+
$this->resolverMock
120+
->expects($this->once())
121+
->method('resolve')
122+
->willReturn('/var/test.js');
123+
$this->assetMinificationMock->expects($this->once())
124+
->method('isMinifiedFilename')
125+
->willReturn(false);
126+
127+
$this->assertEquals('/var/test.js', $this->minification->resolve('', 'test.js'));
128+
}
129+
130+
public function testResolveJsToFindMinifiedVersion()
131+
{
132+
$this->resolverMock
133+
->expects($this->exactly(2))
134+
->method('resolve')
135+
->willReturnMap(
136+
[
137+
['', 'test.js', null, null, null, null, '/var/test.js'],
138+
['', 'test.min.js', null, null, null, null, '/var/test.min.js']
139+
]
140+
);
141+
$this->assetMinificationMock->expects($this->once())
142+
->method('isMinifiedFilename')
143+
->willReturn(false);
144+
$this->assetMinificationMock->expects($this->once())
145+
->method('isEnabled')
146+
->with('js')
147+
->willReturn(true);
148+
$this->assetMinificationMock->expects($this->once())
149+
->method('addMinifiedSign')
150+
->with('test.js')
151+
->willReturn('test.min.js');
152+
153+
$this->assertEquals('/var/test.min.js', $this->minification->resolve('', 'test.js'));
154+
}
155+
156+
public function testResolveJsToNotFindMinifiedVersion()
157+
{
158+
$this->resolverMock
159+
->expects($this->exactly(2))
160+
->method('resolve')
161+
->willReturnMap(
162+
[
163+
['', 'test.js', null, null, null, null, '/var/test.js'],
164+
['', 'test.min.js', null, null, null, null, false]
165+
]
166+
);
167+
$this->assetMinificationMock->expects($this->once())
168+
->method('isMinifiedFilename')
169+
->willReturn(false);
170+
$this->assetMinificationMock->expects($this->once())
171+
->method('isEnabled')
172+
->with('js')
173+
->willReturn(true);
174+
$this->assetMinificationMock->expects($this->once())
175+
->method('addMinifiedSign')
176+
->with('test.js')
177+
->willReturn('test.min.js');
178+
179+
$this->assertEquals('/var/test.js', $this->minification->resolve('', 'test.js'));
180+
}
102181
}

0 commit comments

Comments
 (0)