MAGETWO-44953: Can't import configurable products

MAGETWO-44941: Import History: impossible to download error files for unsuccessful product imports

Author: Yaroslav Onischenko

app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php

@@ -384,6 +384,9 @@ public function saveData()
     public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
     {
         $rowData = array_merge($rowData, $this->transformBundleCustomAttributes($rowData));
+        if (isset($rowData['bundle_price_type']) && $rowData['bundle_price_type'] == 'dynamic') {
+            $rowData['price'] = isset($rowData['price']) && $rowData['price'] ? $rowData['price'] : '0.00';
+        }
         return parent::isRowValid($rowData, $rowNum, $isNewProduct);
     }
 

app/code/Magento/BundleImportExport/Test/Unit/Model/Import/Product/Type/BundleTest.php

@@ -377,8 +377,8 @@ public function testIsRowValid()
     {
         $this->entityModel->expects($this->any())->method('getRowScope')->will($this->returnValue(-1));
         $rowData = [
-            'price_type' => 'fixed',
-            'price_view' => 'bundle_price_view'
+            'bundle_price_type' => 'dynamic',
+            'bundle_price_view' => 'bundle_price_view'
         ];
         $this->assertEquals($this->bundle->isRowValid($rowData, 0), true);
     }

app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php

@@ -418,10 +418,9 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
     {
         $error = false;
         $rowScope = $this->_entityModel->getRowScope($rowData);
-        if ((\Magento\CatalogImportExport\Model\Import\Product::SCOPE_NULL != $rowScope) &&
-            !empty($rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_SKU])) {
-
-
+        if (\Magento\CatalogImportExport\Model\Import\Product::SCOPE_NULL != $rowScope
+            && !empty($rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_SKU])
+        ) {
             foreach ($this->_getProductAttributes($rowData) as $attrCode => $attrParams) {
                 // check value for non-empty in the case of required attribute?
                 if (isset($rowData[$attrCode]) && strlen($rowData[$attrCode])) {
@@ -437,9 +436,7 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
                         ))
                     ) {
                         $this->_entityModel->addRowError(
-                            // @codingStandardsIgnoreStart
-                            \Magento\CatalogImportExport\Model\Import\Product\RowValidatorInterface::ERROR_VALUE_IS_REQUIRED,
-                            // @codingStandardsIgnoreEnd
+                            RowValidatorInterface::ERROR_VALUE_IS_REQUIRED,
                             $rowNum,
                             $attrCode
                         );

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

@@ -104,6 +104,8 @@ public function isRequiredAttributeValid($attrCode, array $attributeParams, arra
         $doCheck = false;
         if ($attrCode == Product::COL_SKU) {
             $doCheck = true;
+        } elseif ($attrCode == 'price') {
+            $doCheck = false;
         } elseif ($attributeParams['is_required'] && $this->getRowScope($rowData) == Product::SCOPE_DEFAULT
             && $this->context->getBehavior() != \Magento\ImportExport\Model\Import::BEHAVIOR_DELETE
         ) {
@@ -124,7 +126,9 @@ public function isRequiredAttributeValid($attrCode, array $attributeParams, arra
     public function isAttributeValid($attrCode, array $attrParams, array $rowData)
     {
         $this->_rowData = $rowData;
-        if (!empty($attrParams['apply_to']) && !in_array($rowData['product_type'], $attrParams['apply_to'])) {
+        if (isset($rowData['product_type']) && !empty($attrParams['apply_to'])
+            && !in_array($rowData['product_type'], $attrParams['apply_to'])
+        ) {
             return true;
         }
 

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/ValidatorTest.php

@@ -147,6 +147,13 @@ public function attributeValidationProvider()
                 ['product_type' => 'any', 'attribute_code' => '1'],
                 true
             ],
+            [
+                Import::BEHAVIOR_APPEND,
+                ['is_required' => true, 'type' => 'decimal'],
+                ['product_type' => 'any', 'price' => ''],
+                true,
+                'price'
+            ],
             [
                 Import::BEHAVIOR_APPEND,
                 ['is_required' => true, 'type' => 'boolean', 'options' => ['yes' => 0, 'no' => 1]],

app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

@@ -802,6 +802,7 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
         $error = false;
         $dataWithExtraVirtualRows = $this->_parseVariations($rowData);
         $skus = [];
+        $rowData['price'] = isset($rowData['price']) && $rowData['price'] ? $rowData['price'] : '0.00';
         if (!empty($dataWithExtraVirtualRows)) {
             array_unshift($dataWithExtraVirtualRows, $rowData);
         } else {

app/code/Magento/ConfigurableProduct/Model/Product/Validator/Plugin.php

@@ -65,6 +65,9 @@ public function aroundValidate(
         \Magento\Framework\App\RequestInterface $request,
         \Magento\Framework\DataObject $response
     ) {
+        if ($request->has('attributes')) {
+            $product->setTypeId(\Magento\ConfigurableProduct\Model\Product\Type\Configurable::TYPE_CODE);
+        }
         $result = $proceed($product, $request, $response);
         $variationProducts = (array)$request->getPost('variations-matrix');
         if ($variationProducts) {

app/code/Magento/ImportExport/Model/Export/Adapter/AbstractAdapter.php

@@ -6,7 +6,7 @@
 namespace Magento\ImportExport\Model\Export\Adapter;
 
 use Magento\Framework\Filesystem;
-use Magento\Framework\Filesystem\DirectoryList;
+use Magento\Framework\App\Filesystem\DirectoryList;
 
 /**
  * Abstract adapter model
@@ -45,7 +45,7 @@ abstract class AbstractAdapter
     public function __construct(
         \Magento\Framework\Filesystem $filesystem,
         $destination = null,
-        $destinationDirectoryCode = DirectoryList::SYS_TMP
+        $destinationDirectoryCode = DirectoryList::VAR_DIR
     ) {
         $this->_directoryHandle = $filesystem->getDirectoryWrite($destinationDirectoryCode);
         if (!$destination) {