Skip to content

Commit b372bdb

Browse files
committed
MC-39463: GraphQL caches urlResolver response and can return the old value after the url rewrite update
1 parent 650aaa6 commit b372bdb

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/UrlRewrite/UrlResolverTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,16 @@ public function testUrlRewriteCleansCacheOnChange(string $requestPath)
8989
};
9090

9191
// warming up urlResolver API response cache for entity and validate proper response
92-
$apiResponse = $this->graphQlQuery($query($requestPath))['urlResolver'];
93-
$this->assertEquals($requestPath, $apiResponse['relative_url']);
92+
$apiResponse = $this->graphQlQuery($query($requestPath));
93+
$this->assertEquals($requestPath, $apiResponse['urlResolver']['relative_url']);
9494

9595
$urlRewrite = $this->getUrlRewriteModelByRequestPath($requestPath, $storeId);
9696

9797
// renaming entity request path and validating that API will not return cached response
9898
$urlRewrite->setRequestPath('test' . $requestPath);
9999
$urlRewriteResourceModel->save($urlRewrite);
100-
$apiResponse = $this->graphQlQuery($query($requestPath))['urlResolver'];
101-
$this->assertNull($apiResponse['relative_url']);
100+
$apiResponse = $this->graphQlQuery($query($requestPath));
101+
$this->assertNull($apiResponse['urlResolver']['relative_url']);
102102

103103
// rolling back changes
104104
$urlRewrite->setRequestPath($requestPath);
@@ -184,20 +184,20 @@ public function testUrlRewriteCleansCacheForCustomRewrites()
184184
$urlRewriteResourceModel->save($urlRewrite);
185185

186186
// confirm that API returns non-cached response for the first custom rewrite
187-
$apiResponse = $this->graphQlQuery($query($customRequestPath))['urlResolver'];
188-
$this->assertEquals($entityRequestPath, $apiResponse['relative_url']);
187+
$apiResponse = $this->graphQlQuery($query($customRequestPath));
188+
$this->assertEquals($entityRequestPath, $apiResponse['urlResolver']['relative_url']);
189189

190190
// confirm that API returns non-cached response for the second custom rewrite
191-
$apiResponse = $this->graphQlQuery($query($customSecondRequestPath))['urlResolver'];
192-
$this->assertEquals($entityRequestPath, $apiResponse['relative_url']);
191+
$apiResponse = $this->graphQlQuery($query($customSecondRequestPath));
192+
$this->assertEquals($entityRequestPath, $apiResponse['urlResolver']['relative_url']);
193193
}
194194

195195
$urlRewriteResourceModel->delete($secondUrlRewrite);
196196

197197
// delete custom rewrite and validate that API will not return cached response
198198
$urlRewriteResourceModel->delete($urlRewrite);
199-
$apiResponse = $this->graphQlQuery($query($customRequestPath))['urlResolver'];
200-
$this->assertNull($apiResponse['relative_url']);
199+
$apiResponse = $this->graphQlQuery($query($customRequestPath));
200+
$this->assertNull($apiResponse['urlResolver']['relative_url']);
201201
}
202202

203203
/**

0 commit comments

Comments
 (0)