MAGETWO-70840: more safe includes on application start #3129

 - Merge Pull Request #3129 from ktomk/magento2:patch/safe-include
 - Merged commits:
   1. d039dac
   2. 5dfd5d1
   3. 95f790b

Author: Oleksii Korshenko

app/etc/NonComposerComponentRegistration.php

@@ -0,0 +1,13 @@
+<?php
+/**
+ * Glob patterns relative to this files parent directory, used by
+ * registration.php to generate a list of includes.
+ */
+return [
+    'code/*/*/cli_commands.php',
+    'code/*/*/registration.php',
+    'design/*/*/*/registration.php',
+    'i18n/*/*/registration.php',
+    '../lib/internal/*/*/registration.php',
+    '../lib/internal/*/*/*/registration.php',
+];

app/etc/registration_globlist.php

@@ -0,0 +1,43 @@
+<?php
+/**
+ * Register components (via a list of glob patterns)
+ *
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\NonComposerComponentRegistration;
+
+use RuntimeException;
+
+/**
+ * Include files from a list of glob patterns
+ *
+ * @throws RuntimeException
+ * @return void
+ */
+function main()
+{
+    $globPatterns = require __DIR__ . '/etc/registration_globlist.php';
+    $baseDir = __DIR__ . '/';
+
+    foreach ($globPatterns as $globPattern) {
+        // Sorting is disabled intentionally for performance improvement
+        $files = glob($baseDir . $globPattern, GLOB_NOSORT);
+        if ($files === false) {
+            throw new RuntimeException("glob(): error with '$baseDir$globPattern'");
+        }
+        array_map(__NAMESPACE__ . '\file', $files);
+    }
+}
+
+/**
+ * Isolated include with it's own variable scope
+ *
+ * @return void
+ */
+function file() {
+    include func_get_arg(0);
+}
+
+main();

app/registration.php

@@ -242,7 +242,7 @@
             ]
         },
         "files": [
-            "app/etc/NonComposerComponentRegistration.php"
+            "app/registration.php"
         ],
         "exclude-from-classmap": [
             "**/dev/**",