Skip to content

Commit b26be92

Browse files
MC-29265: Admin: Add/delete image(s) from configurable product and its child products
1 parent a7e175f commit b26be92

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Controller/Adminhtml/Product/Initialization/HelperTest.php

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ private function setRequestParams(array $childProducts): void
268268
$attribute = $this->productAttributeRepository->get('test_configurable');
269269

270270
foreach ($childProducts as $sku => $product) {
271-
$simpleProduct = $this->getProduct($sku);
271+
$simpleProduct = $this->productRepository->get($sku);
272272
$attributeValue = $simpleProduct->getData('test_configurable');
273273
foreach ($product['images'] as $image => $roles) {
274274
foreach ($roles as $role) {
@@ -338,17 +338,6 @@ private function getMediaGallery(array $imageNames): array
338338
return ['images' => $images];
339339
}
340340

341-
/**
342-
* Returns product by sku.
343-
*
344-
* @param string $sku
345-
* @return ProductInterface
346-
*/
347-
private function getProduct(string $sku): ProductInterface
348-
{
349-
return $this->productRepository->get($sku);
350-
}
351-
352341
/**
353342
* Sets image to child products.
354343
*

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/VariationHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ protected function setUp()
5959
$this->variationHandler = $this->objectManager->create(VariationHandler::class);
6060
$this->product = $this->productRepository->get('configurable');
6161
$this->product->setTypeInstance($this->objectManager->create(Configurable::class));
62-
$this->stockRegistry = Bootstrap::getObjectManager()->get(StockRegistryInterface::class);
62+
$this->stockRegistry = $this->objectManager->get(StockRegistryInterface::class);
6363
}
6464

6565
/**
@@ -74,7 +74,7 @@ public function testGenerateSimpleProducts(array $productsData): void
7474
->setSmallImage('some_test_image.jpg')
7575
->setThumbnail('some_test_image.jpg')
7676
->setSwatchImage('some_test_image.jpg')
77-
->setNewVariationsAttributeSetId(4);
77+
->setNewVariationsAttributeSetId($this->product->getDefaultAttributeSetId());
7878
$generatedProducts = $this->variationHandler->generateSimpleProducts($this->product, $productsData);
7979
$this->assertEquals(3, count($generatedProducts));
8080
foreach ($generatedProducts as $productId) {

0 commit comments

Comments
 (0)