MC-32014: Remove google-shopping-ads module from core in 2.4.1

Author: krissyhiserote

lib/internal/Magento/Framework/DB/Adapter/AdapterInterface.php

@@ -1127,14 +1127,6 @@ public function dropTrigger($triggerName, $schemaName = null);
      */
     public function getTables($likeCondition = null);
 
-    /**
-     * Retrieve triggers list
-     *
-     * @param null|string $likeCondition
-     * @return array
-     */
-    public function getTriggers($likeCondition = null);
-
     /**
      * Generates case SQL fragment
      *

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -4038,19 +4038,6 @@ public function getTables($likeCondition = null)
         return $tables;
     }
 
-    /**
-     * Retrieve triggers list
-     *
-     * @param null|string $likeCondition
-     * @return array
-     */
-    public function getTriggers($likeCondition = null)
-    {
-        $sql = ($likeCondition === null) ? 'SHOW TRIGGERS' : sprintf("SHOW TRIGGERS LIKE '%s'", $likeCondition);
-        $result = $this->query($sql);
-        return $result->fetchAll();
-    }
-
     /**
      * Returns auto increment field if exists
      *

setup/src/Magento/Setup/Console/Command/UpgradeCommand.php

@@ -10,9 +10,13 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\App\State as AppState;
-use Magento\Framework\DB\Ddl\Trigger;
+use Magento\Framework\Console\Cli;
+use Magento\Framework\Exception\RuntimeException;
 use Magento\Framework\Mview\View\CollectionFactory as ViewCollectionFactory;
 use Magento\Framework\Mview\View\StateInterface;
+use Magento\Framework\Mview\View\SubscriptionFactory;
+use Magento\Framework\Mview\View\SubscriptionInterface;
+use Magento\Framework\Mview\ViewInterface;
 use Magento\Framework\Setup\ConsoleLogger;
 use Magento\Framework\Setup\Declaration\Schema\DryRunLogger;
 use Magento\Framework\Setup\Declaration\Schema\OperationsExecutor;
@@ -56,30 +60,48 @@ class UpgradeCommand extends AbstractSetupCommand
      */
     private $searchConfigFactory;
 
-    /*
+    /**
      * @var ViewCollectionFactory
      */
     private $viewCollectionFactory;
 
+    /**
+     * @var SubscriptionFactory
+     */
+    private $subscriptionFactory;
+
+    /**
+     * @var ResourceConnection
+     */
+    private $resource;
+
     /**
      * @param InstallerFactory $installerFactory
      * @param SearchConfigFactory $searchConfigFactory
      * @param DeploymentConfig $deploymentConfig
      * @param AppState|null $appState
      * @param ViewCollectionFactory|null $viewCollectionFactory
+     * @param SubscriptionFactory|null $subscriptionFactory
+     * @param ResourceConnection|null $resource
      */
     public function __construct(
         InstallerFactory $installerFactory,
         SearchConfigFactory $searchConfigFactory,
         DeploymentConfig $deploymentConfig = null,
         AppState $appState = null,
-        ViewCollectionFactory $viewCollectionFactory = null
+        ViewCollectionFactory $viewCollectionFactory = null,
+        SubscriptionFactory $subscriptionFactory = null,
+        ResourceConnection $resource = null
     ) {
         $this->installerFactory = $installerFactory;
         $this->searchConfigFactory = $searchConfigFactory;
         $this->deploymentConfig = $deploymentConfig ?: ObjectManager::getInstance()->get(DeploymentConfig::class);
         $this->appState = $appState ?: ObjectManager::getInstance()->get(AppState::class);
-        $this->viewCollectionFactory = $viewCollectionFactory ?: ObjectManager::getInstance()->get(ViewCollectionFactory::class);
+        $this->viewCollectionFactory = $viewCollectionFactory
+            ?: ObjectManager::getInstance()->get(ViewCollectionFactory::class);
+        $this->subscriptionFactory = $subscriptionFactory
+            ?: ObjectManager::getInstance()->get(SubscriptionFactory::class);
+        $this->resource = $resource ?: ObjectManager::getInstance()->get(ResourceConnection::class);
         parent::__construct();
     }
 
@@ -142,9 +164,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $installer->updateModulesSequence($keepGenerated);
             $searchConfig = $this->searchConfigFactory->create();
             $searchConfig->validateSearchEngine();
-
             $this->removeUnusedTriggers();
-
             $installer->installSchema($request);
             $installer->installDataFixtures($request);
 
@@ -153,8 +173,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $arrayInput = new ArrayInput([]);
                 $arrayInput->setInteractive($input->isInteractive());
                 $result = $importConfigCommand->run($arrayInput, $output);
-                if ($result === \Magento\Framework\Console\Cli::RETURN_FAILURE) {
-                    throw new \Magento\Framework\Exception\RuntimeException(
+                if ($result === Cli::RETURN_FAILURE) {
+                    throw new RuntimeException(
                         __('%1 failed. See previous output.', ConfigImportCommand::COMMAND_NAME)
                     );
                 }
@@ -167,49 +187,70 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         } catch (\Exception $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');
-            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+            return Cli::RETURN_FAILURE;
         }
 
-        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
+        return Cli::RETURN_SUCCESS;
     }
 
     /**
      * Remove unused triggers
      */
     private function removeUnusedTriggers()
     {
-        // unsubscribe mview
         $viewCollection = $this->viewCollectionFactory->create();
         $viewList = $viewCollection->getViewsByStateMode(StateInterface::MODE_ENABLED);
+
+        // Unsubscribe mviews
         foreach ($viewList as $view) {
-            /** @var \Magento\Framework\Mview\ViewInterface $view */
+            /** @var ViewInterface $view */
             $view->unsubscribe();
         }
 
-        // remove extra triggers that have correct naming structure
-        /** @var ResourceConnection $resource */
-        $resource = ObjectManager::getInstance()->get(ResourceConnection::class);
-        $connection = $resource->getConnection();
-        $triggers = $connection->getTriggers();
+        // Remove extra triggers that have correct naming structure
+        $triggers = $this->getTriggers();
         foreach ($triggers as $trigger) {
-            $triggerNames = [];
-            foreach (Trigger::getListOfEvents() as $event) {
-                $triggerName = $resource->getTriggerName(
-                    $resource->getTableName($trigger['Table']),
-                    Trigger::TIME_AFTER,
-                    $event
-                );
-                $triggerNames[] = strtolower($triggerName);
-            }
-            if (in_array($trigger['Trigger'], $triggerNames)) {
-                $connection->dropTrigger($trigger['Trigger']);
-            }
+            $this->initSubscriptionInstance($trigger['Table'])->remove();
         }
 
-        // subscribe mview
+        // Subscribe mviews
         foreach ($viewList as $view) {
-            /** @var \Magento\Framework\Mview\ViewInterface $view */
+            /** @var ViewInterface $view */
             $view->subscribe();
         }
     }
+
+    /**
+     * Retrieve triggers list
+     *
+     * @return array
+     */
+    private function getTriggers(): array
+    {
+        $connection = $this->resource->getConnection();
+        $result = $connection->query('SHOW TRIGGERS');
+        return $result->fetchAll();
+    }
+
+    /**
+     * Initializes subscription instance
+     *
+     * @param string $tablename
+     * @return SubscriptionInterface
+     */
+    private function initSubscriptionInstance(string $tablename): SubscriptionInterface
+    {
+        /** @var ViewInterface $view */
+        $view = ObjectManager::getInstance()->create(ViewInterface::class);
+        $view->setId('0');
+
+        return $this->subscriptionFactory->create(
+            [
+                'view' => $view,
+                'tableName' => $tablename,
+                'columnName' => '',
+                'subscriptionModel' => SubscriptionFactory::INSTANCE_NAME,
+            ]
+        );
+    }
 }