MAGETWO-65208: Store checksum for every section of configuration file & change behavior on read-only FS & add sorting of importers

Author: Bohdan Korablov

app/code/Magento/Deploy/Model/Plugin/ConfigValidator.php

@@ -6,7 +6,7 @@
 namespace Magento\Deploy\Model\Plugin;
 
 use Magento\Deploy\Model\DeploymentConfig\Validator as DeploymentConfigValidator;
-use Magento\Framework\App\FrontController;
+use Magento\Framework\App\FrontControllerInterface;
 use Magento\Framework\App\RequestInterface;
 use Magento\Framework\Exception\LocalizedException;
 
@@ -37,13 +37,13 @@ public function __construct(DeploymentConfigValidator $configValidator)
     /**
      * Performs check that config data from deployment configuration files is valid.
      *
-     * @param FrontController $subject the object of controller is wrapped by this plugin
+     * @param FrontControllerInterface $subject the interface of frontend controller is wrapped by this plugin
      * @param RequestInterface $request the object that contains request params
      * @return void
      * @throws LocalizedException is thrown if config data from deployment configuration files is not valid
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeDispatch(FrontController $subject, RequestInterface $request)
+    public function beforeDispatch(FrontControllerInterface $subject, RequestInterface $request)
     {
         if (!$this->configValidator->isValid()) {
             throw new LocalizedException(

app/code/Magento/Deploy/Test/Unit/Model/Plugin/ConfigValidatorTest.php

@@ -7,7 +7,7 @@
 
 use Magento\Deploy\Model\Plugin\ConfigValidator;
 use Magento\Deploy\Model\DeploymentConfig\Validator;
-use Magento\Framework\App\FrontController;
+use Magento\Framework\App\FrontControllerInterface;
 use Magento\Framework\App\RequestInterface;
 
 class ConfigValidatorTest extends \PHPUnit_Framework_TestCase
@@ -23,7 +23,7 @@ class ConfigValidatorTest extends \PHPUnit_Framework_TestCase
     private $configValidatorMock;
 
     /**
-     * @var FrontController|\PHPUnit_Framework_MockObject_MockObject
+     * @var FrontControllerInterface|\PHPUnit_Framework_MockObject_MockObject
      */
     private $frontControllerMock;
 
@@ -40,9 +40,8 @@ protected function setUp()
         $this->configValidatorMock = $this->getMockBuilder(Validator::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->frontControllerMock = $this->getMockBuilder(FrontController::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->frontControllerMock = $this->getMockBuilder(FrontControllerInterface::class)
+            ->getMockForAbstractClass();
         $this->requestMock = $this->getMockBuilder(RequestInterface::class)
             ->getMockForAbstractClass();