MAGETWO-96118: Few optimizations on category & product pages

Author: slopukhov

app/code/Magento/Catalog/Model/Product/Gallery/ReadHandler.php

@@ -47,6 +47,8 @@ public function __construct(
     }
 
     /**
+     * Execute read handler for catalog product gallery
+     *
      * @param Product $entity
      * @param array $arguments
      * @return object
@@ -69,6 +71,8 @@ public function execute($entity, $arguments = [])
     }
 
     /**
+     * Add media data to product
+     *
      * @param Product $product
      * @param array $mediaEntries
      * @return void
@@ -86,6 +90,8 @@ public function addMediaDataToProduct(Product $product, array $mediaEntries)
     }
 
     /**
+     * Get attribute
+     *
      * @return \Magento\Catalog\Api\Data\ProductAttributeInterface
      * @since 101.0.0
      */
@@ -99,6 +105,8 @@ public function getAttribute()
     }
 
     /**
+     * Find default value
+     *
      * @param string $key
      * @param string[] &$image
      * @return string

app/code/Magento/Catalog/Model/ResourceModel/Product/Gallery.php

@@ -49,7 +49,8 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @since 101.0.0
      */
     protected function _construct()
@@ -58,7 +59,8 @@ protected function _construct()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @since 101.0.0
      */
     public function getConnection()
@@ -67,6 +69,8 @@ public function getConnection()
     }
 
     /**
+     * Load data from table by valueId
+     *
      * @param string $tableNameAlias
      * @param array $ids
      * @param int|null $storeId
@@ -111,6 +115,8 @@ public function loadDataFromTableByValueId(
     }
 
     /**
+     * Load product gallery by attributeId
+     *
      * @param \Magento\Catalog\Model\Product $product
      * @param int $attributeId
      * @return array
@@ -132,6 +138,8 @@ public function loadProductGalleryByAttributeId($product, $attributeId)
     }
 
     /**
+     * Create base load select
+     *
      * @param int $entityId
      * @param int $storeId
      * @param int $attributeId
@@ -151,6 +159,8 @@ protected function createBaseLoadSelect($entityId, $storeId, $attributeId)
     }
 
     /**
+     * Create batch base select
+     *
      * @param int $storeId
      * @param int $attributeId
      * @return \Magento\Framework\DB\Select
@@ -247,6 +257,8 @@ protected function removeDuplicates(&$result)
     }
 
     /**
+     * Get main table alias
+     *
      * @return string
      * @since 101.0.0
      */
@@ -256,6 +268,8 @@ public function getMainTableAlias()
     }
 
     /**
+     * Bind value to entity
+     *
      * @param int $valueId
      * @param int $entityId
      * @return int
@@ -273,6 +287,8 @@ public function bindValueToEntity($valueId, $entityId)
     }
 
     /**
+     * Save data row
+     *
      * @param string $table
      * @param array $data
      * @param array $fields

app/code/Magento/ConfigurableProduct/Model/ResourceModel/Product/Type/Configurable.php

@@ -19,6 +19,9 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\DB\Adapter\AdapterInterface;
 
+/**
+ * Configurable product resource model.
+ */
 class Configurable extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb
 {
     /**

app/code/Magento/ConfigurableProduct/Plugin/Catalog/Model/Product/Pricing/Renderer/SalableResolver.php

@@ -27,8 +27,7 @@ public function __construct(
     }
 
     /**
-     * Performs an additional check whether given configurable product has
-     * at least one configuration in-stock.
+     * Performs an additional check whether given configurable product has at least one configuration in-stock.
      *
      * @param \Magento\Catalog\Model\Product\Pricing\Renderer\SalableResolver $subject
      * @param bool $result

app/code/Magento/ProductVideo/Model/Plugin/ExternalVideoResourceBackend.php

@@ -27,6 +27,8 @@ public function __construct(\Magento\ProductVideo\Model\ResourceModel\Video $vid
     }
 
     /**
+     * Plugin for after duplicate action
+     *
      * @param Gallery $originalResourceModel
      * @param array $valueIdMap
      * @return array
@@ -45,6 +47,8 @@ public function afterDuplicate(Gallery $originalResourceModel, array $valueIdMap
     }
 
     /**
+     * Plugin for after create batch base select action
+     *
      * @param Gallery $originalResourceModel
      * @param Select $select
      * @return Select
@@ -62,7 +66,11 @@ public function afterCreateBatchBaseSelect(Gallery $originalResourceModel, Selec
             ),
             []
         )->joinLeft(
-            ['default_value_video' => $originalResourceModel->getTable('catalog_product_entity_media_gallery_value_video')],
+            [
+                'default_value_video' => $originalResourceModel->getTable(
+                    'catalog_product_entity_media_gallery_value_video'
+                )
+            ],
             implode(
                 ' AND ',
                 [