MAGETWO-38844: Contribution of Ogres Sprint 31

- fixed unit test
- suppressed static test

Author: eddielau

lib/internal/Magento/Framework/Module/ModuleList/Loader.php

@@ -15,6 +15,8 @@
 
 /**
  * Loader of module list information from the filesystem
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Loader
 {

lib/internal/Magento/Framework/Module/Test/Unit/ModuleList/LoaderTest.php

@@ -122,15 +122,16 @@ public function testLoadExclude()
             ['c', null, null, self::$sampleXml],
             ['d', null, null, self::$sampleXml],
         ]));
+        $this->registry->expects($this->once())
+            ->method('getModulePaths')
+            ->willReturn([]);
         $this->converter->expects($this->at(0))->method('convert')->willReturn(['a' => $fixture['a']]);
         $this->converter->expects($this->at(1))->method('convert')->willReturn(['b' => $fixture['b']]);
         $this->converter->expects($this->at(2))->method('convert')->willReturn(['c' => $fixture['c']]);
         $this->converter->expects($this->at(3))->method('convert')->willReturn(['d' => $fixture['d']]);
-        $this->parser->expects($this->once())->method('initErrorHandler');
         $this->parser->expects($this->atLeastOnce())->method('loadXML');
         $this->parser->expects($this->atLeastOnce())->method('getDom');
-        $object = new Loader($this->filesystem, $this->converter, $this->parser);
-        $result = $object->load(['d']);
+        $result = $this->loader->load(['d']);
         $this->assertSame(['a', 'c', 'b'], array_keys($result));
         $this->assertSame($fixture['a'], $result['a']);
         $this->assertSame($fixture['b'], $result['b']);