MAGETWO-95628: Filesystem Directory Improvement

Author: StasKozar

lib/internal/Magento/Framework/Filesystem/Directory/PathValidator.php

@@ -40,7 +40,7 @@ public function validate(
         $absolutePath = false
     ) {
         $realDirectoryPath = $this->driver->getRealPathSafety($directoryPath);
-        if ($realDirectoryPath[-1] !== DIRECTORY_SEPARATOR) {
+        if (substr($realDirectoryPath, -1) !== DIRECTORY_SEPARATOR) {
             $realDirectoryPath .= DIRECTORY_SEPARATOR;
         }
         if (!$absolutePath) {

lib/internal/Magento/Framework/Filesystem/Directory/Read.php

@@ -138,6 +138,7 @@ public function read($path = null)
         foreach ($files as $file) {
             $result[] = $this->getRelativePath($file);
         }
+
         return $result;
     }
 
@@ -158,6 +159,7 @@ public function readRecursively($path = null)
             $result[] = $this->getRelativePath($file);
         }
         sort($result);
+
         return $result;
     }
 
@@ -183,6 +185,7 @@ public function search($pattern, $path = null)
         foreach ($files as $file) {
             $result[] = $this->getRelativePath($file);
         }
+
         return $result;
     }
 
@@ -259,8 +262,8 @@ public function readFile($path, $flag = null, $context = null)
         $this->validatePath($path);
 
         $absolutePath = $this->driver->getAbsolutePath($this->path, $path);
-        return $this->driver->fileGetContents($absolutePath, $flag, $context);
 
+        return $this->driver->fileGetContents($absolutePath, $flag, $context);
     }
 
     /**