ENGCOM-2970: Replace floatval() function by using direct type casting to (float) #18020

Author: Stanislav Idolov

dev/tests/functional/lib/Magento/Mtf/Constraint/AbstractAssertForm.php

@@ -53,7 +53,7 @@ protected function verifyData(array $fixtureData, array $formData, $isStrict = f
             }
             $formValue = isset($formData[$key]) ? $formData[$key] : null;
             if (is_numeric($formValue)) {
-                $formValue = floatval($formValue);
+                $formValue = (float)$formValue;
             }
 
             if (null === $formValue) {

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/View/CustomOptions.php

@@ -231,7 +231,7 @@ protected function getFieldData(SimpleElement $option)
         return [
             'options' => [
                 [
-                    'price' => floatval($price),
+                    'price' => (float)$price,
                     'max_characters' => $maxCharacters,
                 ],
             ]
@@ -262,7 +262,7 @@ protected function getFileData(SimpleElement $option)
         return [
             'options' => [
                 [
-                    'price' => floatval($price),
+                    'price' => (float)$price,
                     'file_extension' => $this->getOptionNotice($option, 1),
                     'image_size_x' => preg_replace('/[^0-9]/', '', $this->getOptionNotice($option, 2)),
                     'image_size_y' => preg_replace('/[^0-9]/', '', $this->getOptionNotice($option, 3)),
@@ -344,7 +344,7 @@ protected function getDateData(SimpleElement $option)
         return [
             'options' => [
                 [
-                    'price' => floatval($price),
+                    'price' => (float)$price,
                 ],
             ]
         ];

dev/tests/functional/tests/app/Magento/CatalogRule/Test/Constraint/AssertCatalogPriceRuleForm.php

@@ -42,10 +42,10 @@ public function processAssert(
         $fixtureData = $catalogPriceRule->getData();
         //convert discount_amount to float to compare
         if (isset($formData['discount_amount'])) {
-            $formData['discount_amount'] = floatval($formData['discount_amount']);
+            $formData['discount_amount'] = (float)$formData['discount_amount'];
         }
         if (isset($fixtureData['discount_amount'])) {
-            $fixtureData['discount_amount'] = floatval($fixtureData['discount_amount']);
+            $fixtureData['discount_amount'] = (float)$fixtureData['discount_amount'];
         }
         $diff = $this->verifyData($formData, $fixtureData);
         \PHPUnit\Framework\Assert::assertTrue(

dev/tests/functional/tests/app/Magento/Downloadable/Test/Handler/DownloadableProduct/Webapi.php

@@ -148,7 +148,7 @@ protected function prepareLinkData(array $link)
             'title' => $link['title'],
             'sort_order' => isset($link['sort_order']) ? $link['sort_order'] : 0,
             'is_shareable' => $link['is_shareable'],
-            'price' => floatval($link['price']),
+            'price' => (float)$link['price'],
             'number_of_downloads' => isset($link['number_of_downloads']) ? $link['number_of_downloads'] : 0,
             'link_type' => $link['type'],
             'link_url' => isset($link['link_url']) ? $link['link_url'] : null,

dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertSalesReportIntervalResult.php

@@ -52,7 +52,7 @@ protected function prepareSalesResult($salesResult)
     {
         $data = [];
         foreach ($salesResult as $key => $result) {
-            $data[$key] = floatval($result);
+            $data[$key] = (float)$result;
         }
 
         return $data;

dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertSalesReportTotalResult.php

@@ -52,7 +52,7 @@ protected function prepareSalesResult($salesResult)
     {
         $data = [];
         foreach ($salesResult as $key => $result) {
-            $data[$key] = floatval($result);
+            $data[$key] = (float)$result;
         }
 
         return $data;

dev/tests/integration/testsuite/Magento/Catalog/Model/ProductTest.php

@@ -585,7 +585,7 @@ public function testGetOptions()
                 continue;
             }
             foreach ($option->getValues() as $value) {
-                $this->assertEquals($expectedValue[$value->getSku()], floatval($value->getPrice()));
+                $this->assertEquals($expectedValue[$value->getSku()], (float)$value->getPrice());
             }
         }
     }

lib/internal/Magento/Framework/Filter/Template/Tokenizer/Variable.php

@@ -313,6 +313,6 @@ public function getNumber()
         if (!$this->isNumeric()) {
             $this->prev();
         }
-        return floatval($value);
+        return (float)$value;
     }
 }

lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Factories/Real.php

@@ -63,7 +63,7 @@ public function create(array $data)
         }
 
         if (isset($data['default'])) {
-            $data['default'] = floatval($data['default']);
+            $data['default'] = (float)$data['default'];
         }
 
         return $this->objectManager->create($this->className, $data);