ACP2E-957: Re: Problem in import products module (Merchant made a patch & asking us to fix in core magento)

Author: thiaramus

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest/ProductUrlKeyTest.php

@@ -8,12 +8,16 @@
 namespace Magento\CatalogImportExport\Model\Import\ProductTest;
 
 use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Catalog\Test\Fixture\Product as ProductFixture;
 use Magento\CatalogImportExport\Model\Import\Product\RowValidatorInterface;
 use Magento\CatalogImportExport\Model\Import\ProductTestBase;
 use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Filesystem;
 use Magento\ImportExport\Model\Import;
 use Magento\ImportExport\Model\Import\Source\Csv;
+use Magento\TestFramework\Fixture\Config;
+use Magento\TestFramework\Fixture\DataFixture;
 
 /**
  * Integration test for \Magento\CatalogImportExport\Model\Import\Product class.
@@ -67,7 +71,7 @@ public function testImportWithoutUrlKeysAndName()
      * @dataProvider validateUrlKeysDataProvider
      * @param $importFile string
      * @param $expectedErrors array
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     public function testValidateUrlKeys($importFile, $expectedErrors)
     {
@@ -306,7 +310,7 @@ public function testImportWithoutUrlKeys()
     /**
      * @magentoDataFixture Magento/Catalog/_files/product_simple_with_non_latin_url_key.php
      * @return void
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     public function testImportWithNonLatinUrlKeys()
     {
@@ -352,7 +356,7 @@ public function testImportWithNonLatinUrlKeys()
      * @magentoDbIsolation disabled
      * @magentoAppIsolation enabled
      * @return void
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     public function testImportWithSpacesInUrlKeys()
     {
@@ -384,4 +388,45 @@ public function testImportWithSpacesInUrlKeys()
             $this->assertEquals($productUrlKey, $productRepository->get($productSku)->getUrlKey());
         }
     }
+
+    /**
+     * Validate import file when we have an existing product with UrlKey that consists of an alpha characters and
+     * a number at the end against the same imported UrlKey but without the number at the end,
+     * when Product URL Suffix is set to none in the admin.
+     *
+     * @throws LocalizedException
+     */
+    #[
+        Config('catalog/seo/product_url_suffix', null, 'store', 'default'),
+        DataFixture(
+            ProductFixture::class,
+            [
+                'url_key' => '1234t',
+                'url_path' => '1234t'
+            ],
+        ),
+    ]
+    public function testValidateMixedCharNumUrlKeysWithNullUrlSuffix()
+    {
+        $filesystem = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+            \Magento\Framework\Filesystem::class
+        );
+        $directory = $filesystem->getDirectoryWrite(DirectoryList::ROOT);
+
+        $source = $this->objectManager->create(
+            \Magento\ImportExport\Model\Import\Source\Csv::class,
+            [
+                'file' => __DIR__ . '/../_files/products_to_check_valid_url_keys_mixed_chars_nums.csv',
+                'directory' => $directory
+            ]
+        );
+
+        $errors = $this->_model->setParameters(
+            ['behavior' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND, 'entity' => 'catalog_product']
+        )->setSource(
+            $source
+        )->validateData();
+
+        $this->assertEmpty($errors->getAllErrors(), 'Assert that import validation returns no errors');
+    }
 }

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/_files/products_to_check_valid_url_keys_mixed_chars_nums.csv

@@ -0,0 +1,2 @@
+sku,product_type,store_view_code,name,price,attribute_set_code,url_key
+simple1,simple,,"simple 1",25,Default,1234