Move _getAllIdsSelect into the grid collection

Author: dmanners

app/code/Magento/Cms/Model/ResourceModel/Block/Collection.php

@@ -78,24 +78,4 @@ protected function _renderFiltersBefore()
         $entityMetadata = $this->metadataPool->getMetadata(BlockInterface::class);
         $this->joinStoreRelationTable('cms_block_store', $entityMetadata->getLinkField());
     }
-
-    /**
-     * Create all ids retrieving select with limitation
-     * Backward compatibility with EAV collection
-     *
-     * @param int $limit
-     * @param int $offset
-     * @return \Magento\Eav\Model\Entity\Collection\AbstractCollection
-     */
-    protected function _getAllIdsSelect($limit = null, $offset = null)
-    {
-        $idsSelect = clone $this->getSelect();
-        $idsSelect->reset(\Magento\Framework\DB\Select::ORDER);
-        $idsSelect->reset(\Magento\Framework\DB\Select::LIMIT_COUNT);
-        $idsSelect->reset(\Magento\Framework\DB\Select::LIMIT_OFFSET);
-        $idsSelect->reset(\Magento\Framework\DB\Select::COLUMNS);
-        $idsSelect->columns($this->getResource()->getIdFieldName(), 'main_table');
-        $idsSelect->limit($limit, $offset);
-        return $idsSelect;
-    }
 }

app/code/Magento/Cms/Model/ResourceModel/Block/Grid/Collection.php

@@ -91,12 +91,33 @@ public function setAggregations($aggregations)
      * @param int $limit
      * @param int $offset
      * @return array
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function getAllIds($limit = null, $offset = null)
     {
         return $this->getConnection()->fetchCol($this->_getAllIdsSelect($limit, $offset), $this->_bindParams);
     }
 
+    /**
+     * Create all ids retrieving select with limitation
+     *
+     * @param int $limit
+     * @param int $offset
+     * @return \Magento\Framework\DB\Select
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
+    protected function _getAllIdsSelect($limit = null, $offset = null)
+    {
+        $idsSelect = clone $this->getSelect();
+        $idsSelect->reset(\Magento\Framework\DB\Select::ORDER);
+        $idsSelect->reset(\Magento\Framework\DB\Select::LIMIT_COUNT);
+        $idsSelect->reset(\Magento\Framework\DB\Select::LIMIT_OFFSET);
+        $idsSelect->reset(\Magento\Framework\DB\Select::COLUMNS);
+        $idsSelect->columns($this->getResource()->getIdFieldName(), 'main_table');
+        $idsSelect->limit($limit, $offset);
+        return $idsSelect;
+    }
+
     /**
      * Get search criteria.
      *