Skip to content

Commit aeb5719

Browse files
Merge remote-tracking branch 'remotes/github/2.3-develop' into EPAM-PR-42
2 parents b390547 + 16036cd commit aeb5719

File tree

46 files changed

+431
-93
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+431
-93
lines changed

app/code/Magento/Catalog/Controller/Adminhtml/Product/GridOnly.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
<?php
22
/**
3-
*
43
* Copyright © Magento, Inc. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
76
namespace Magento\Catalog\Controller\Adminhtml\Product;
87

9-
class GridOnly extends \Magento\Catalog\Controller\Adminhtml\Product
8+
use Magento\Framework\App\Action\HttpGetActionInterface;
9+
10+
/**
11+
* Get specified tab grid controller.
12+
*/
13+
class GridOnly extends \Magento\Catalog\Controller\Adminhtml\Product implements HttpGetActionInterface
1014
{
1115
/**
1216
* @var \Magento\Framework\Controller\Result\RawFactory
@@ -47,7 +51,7 @@ public function execute()
4751
$this->productBuilder->build($this->getRequest());
4852

4953
$block = $this->getRequest()->getParam('gridOnlyBlock');
50-
$blockClassSuffix = str_replace(' ', '_', ucwords(str_replace('_', ' ', $block)));
54+
$blockClassSuffix = ucwords($block, '_');
5155

5256
/** @var \Magento\Framework\Controller\Result\Raw $resultRaw */
5357
$resultRaw = $this->resultRawFactory->create();

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/CurrentUrlRewritesRegeneratorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ protected function getCurrentRewritesMocks($currentRewrites)
252252
->disableOriginalConstructor()->getMock();
253253
foreach ($urlRewrite as $key => $value) {
254254
$url->expects($this->any())
255-
->method('get' . str_replace(' ', '', ucwords(str_replace('_', ' ', $key))))
255+
->method('get' . str_replace('_', '', ucwords($key, '_')))
256256
->will($this->returnValue($value));
257257
}
258258
$rewrites[] = $url;

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Product/CurrentUrlRewritesRegeneratorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ protected function getCurrentRewritesMocks($currentRewrites)
294294
->disableOriginalConstructor()->getMock();
295295
foreach ($urlRewrite as $key => $value) {
296296
$url->expects($this->any())
297-
->method('get' . str_replace(' ', '', ucwords(str_replace('_', ' ', $key))))
297+
->method('get' . str_replace('_', '', ucwords($key, '_')))
298298
->will($this->returnValue($value));
299299
}
300300
$rewrites[] = $url;

app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/AfterImportDataObserverTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ protected function currentUrlRewritesRegeneratorGetCurrentRewritesMocks($current
694694
->disableOriginalConstructor()->getMock();
695695
foreach ($urlRewrite as $key => $value) {
696696
$url->expects($this->any())
697-
->method('get' . str_replace(' ', '', ucwords(str_replace('_', ' ', $key))))
697+
->method('get' . str_replace('_', '', ucwords($key, '_')))
698698
->will($this->returnValue($value));
699699
}
700700
$rewrites[] = $url;

app/code/Magento/Checkout/view/frontend/web/js/model/quote.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
*/
88
define([
99
'ko',
10-
'underscore'
10+
'underscore',
11+
'domReady!'
1112
], function (ko, _) {
1213
'use strict';
1314

app/code/Magento/Config/Model/Config.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,11 @@ protected function _processGroup(
424424
if (!isset($fieldData['value'])) {
425425
$fieldData['value'] = null;
426426
}
427+
428+
if ($field->getType() == 'multiline' && is_array($fieldData['value'])) {
429+
$fieldData['value'] = trim(implode(PHP_EOL, $fieldData['value']));
430+
}
431+
427432
$data = [
428433
'field' => $fieldId,
429434
'groups' => $groups,

app/code/Magento/Customer/Block/Form/Login.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,6 @@ public function __construct(
4747
$this->_customerSession = $customerSession;
4848
}
4949

50-
/**
51-
* @return $this
52-
*/
53-
protected function _prepareLayout()
54-
{
55-
$this->pageConfig->getTitle()->set(__('Customer Login'));
56-
return parent::_prepareLayout();
57-
}
58-
5950
/**
6051
* Retrieve form posting url
6152
*

app/code/Magento/Customer/view/frontend/layout/customer_account_login.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
*/
77
-->
88
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
9+
<head>
10+
<title>Customer Login</title>
11+
</head>
912
<body>
1013
<referenceContainer name="content">
1114
<!-- customer.form.login.extra -->

app/code/Magento/Eav/Model/Attribute/Data/File.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ protected function _validateByRules($value)
146146
return $this->_fileValidator->getMessages();
147147
}
148148

149-
if (empty($value['tmp_name'])) {
149+
if (!empty($value['tmp_name']) && !file_exists($value['tmp_name'])) {
150150
return [__('"%1" is not a valid file.', $label)];
151151
}
152152

app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ public function addAttributeToFilter($attribute, $condition = null, $joinType =
415415
*/
416416
public function addFieldToFilter($attribute, $condition = null)
417417
{
418-
return $this->addAttributeToFilter($attribute, $condition);
418+
return $this->addAttributeToFilter($attribute, $condition, 'left');
419419
}
420420

421421
/**

0 commit comments

Comments
 (0)