B2B-582: Update history log messages for Order Approvals

 - fix integrity test to detect all sprintf placeholders

Author: cspruiell

dev/tests/static/testsuite/Magento/Test/Integrity/Phrase/ArgumentsTest.php

@@ -99,14 +99,14 @@ private function checkArgumentMismatch($phrase, &$incorrectNumberOfArgumentsErro
     {
         if (preg_match_all('/%(\w+)/', $phrase['phrase'], $matches) || $phrase['arguments']) {
             $placeholderCount = count(array_unique($matches[1]));
-            // count all occurrences of %s
-            preg_match_all('/%s/', $phrase['phrase'], $sprintfMatches);
-            if (count($sprintfMatches[0]) > 1) {
-                $placeholderCount = $placeholderCount + count($sprintfMatches[0]) - 1;
+            // count all occurrences of sprintf placeholders
+            preg_match_all('/%([sducoxXbgGeEfF])/', $phrase['phrase'], $sprintfMatches);
+            if (count($sprintfMatches[0]) > count(array_unique($sprintfMatches[0]))) {
+                $placeholderCount = $placeholderCount + count($sprintfMatches[0]) - count(array_unique($sprintfMatches[0]));
             }
 
-            // Check for zend placeholders %placeholder% and sprintf placeholder %s
-            if (preg_match_all('/%((s)|([A-Za-z]+)%)/', $phrase['phrase'], $placeHolders, PREG_OFFSET_CAPTURE)) {
+            // Check for zend placeholders %placeholder% and sprintf placeholders
+            if (preg_match_all('/%(([sducoxXbgGeEfF])|([A-Za-z]+)%)/', $phrase['phrase'], $placeHolders, PREG_OFFSET_CAPTURE)) {
                 foreach ($placeHolders[0] as $ph) {
                     // Check if char after placeholder is not a digit or letter
                     $charAfterPh = $phrase['phrase'][$ph[1] + strlen($ph[0])];