Duplicated option value detection logic moved to separate function

Author: vovayatsyuk

lib/web/mage/sticky.js

@@ -17,6 +17,22 @@ define([
             stickyClass: '_sticky'
         },
 
+        _optionToNumber(option) {
+            var value = this.options[option] || 0;
+            if (typeof value === 'function') {
+                value = this.options[option]();
+            }
+
+            var converted = Number(value);
+            if (isNaN(converted)) {
+                throw Error(
+                    'sticky: Could not convert supplied option "' +
+                    option + '" to Number from "' + value + '"'
+                );
+            }
+            return converted;
+        },
+
         /**
          * Bind handlers to scroll event
          * @private
@@ -43,25 +59,15 @@ define([
             isStatic = this.element.css('position') === 'static';
 
             if (!isStatic && this.element.is(':visible')) {
-                offset = $(document).scrollTop() - this.parentOffset;
-
-                if (typeof this.options.spacingTop === 'function') {
-                    offset += this.options.spacingTop();
-                } else {
-                    offset += this.options.spacingTop;
-                }
+                offset = $(document).scrollTop()
+                    - this.parentOffset
+                    + this._optionToNumber('spacingTop');
 
                 offset = Math.max(0, Math.min(offset, this.maxOffset));
 
                 var stuck = this.element.hasClass(this.options.stickyClass);
                 if (offset && this.options.offsetTop && !stuck) {
-                    var offsetTop = 0;
-                    if (typeof this.options.offsetTop === 'function') {
-                        offsetTop = this.options.offsetTop();
-                    } else {
-                        offsetTop = this.options.offsetTop;
-                    }
-
+                    var offsetTop = this._optionToNumber('offsetTop');
                     if (offset < offsetTop) {
                         offset = 0;
                     }