ECP-261: Offload Catalog Image Resizing from Magento

- Fixed tests
- Suppressed excessive coupling warning in Helper/Image because it is an @api class with dependencies in protected properties (cannot be refactored in backward compatible manner)

Author: paliarush

app/code/Magento/Catalog/Helper/Image.php

@@ -13,10 +13,11 @@
 use Magento\Framework\View\Element\Block\ArgumentInterface;
 
 /**
- * Catalog image helper
+ * Catalog image helper.
  *
  * @api
  * @SuppressWarnings(PHPMD.TooManyFields)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @since 100.0.2
  */
 class Image extends AbstractHelper implements ArgumentInterface
@@ -163,8 +164,7 @@ public function __construct(
         $this->_assetRepo = $assetRepo;
         $this->viewConfig = $viewConfig;
         $this->viewAssetPlaceholderFactory = $placeholderFactory
-            ?: ObjectManager::getInstance()
-                ->get(PlaceholderFactory::class);
+            ?: ObjectManager::getInstance()->get(PlaceholderFactory::class);
         $this->mediaConfig = $mediaConfig ?: ObjectManager::getInstance()->get(CatalogMediaConfig::class);
     }
 
@@ -394,9 +394,10 @@ public function constrainOnly($flag)
      */
     public function backgroundColor($colorRGB)
     {
+        $args = func_get_args();
         // assume that 3 params were given instead of array
         if (!is_array($colorRGB)) {
-            $colorRGB = func_get_args();
+            $colorRGB = $args;
         }
         $this->_getModel()->setBackgroundColor($colorRGB);
         return $this;

app/code/Magento/MediaStorage/Console/Command/ImagesResizeCommand.php

@@ -86,7 +86,8 @@ protected function configure()
         $this->setName('catalog:images:resize')
             ->setDescription(
                 'Creates resized product images ' .
-                '(Not relevant when image resizing is offloaded from Magento. See https://docs.magento.com/m2/ee/user_guide/configuration/general/web.html#url-options )'
+                '(Not relevant when image resizing is offloaded from Magento. ' .
+                'See https://docs.magento.com/m2/ee/user_guide/configuration/general/web.html#url-options )'
             )
             ->setDefinition($this->getOptionsList());
     }

app/code/Magento/Store/Test/Unit/Model/HeaderProvider/UpgradeInsecureTest.php

@@ -19,7 +19,7 @@ class UpgradeInsecureTest extends \PHPUnit\Framework\TestCase
     /**
      * Content-Security-Policy header value
      */
-    const HEADER_VALUE = 'upgrade-insecure-requests;';
+    const HEADER_VALUE = 'upgrade-insecure-requests';
 
     /**
      * @var UpgradeInsecure