Skip to content

Commit add5e3d

Browse files
committed
MC-2294: Image still displayed after deleting it from Media Gallery Storage
- Added test and cleaned up
1 parent 310074f commit add5e3d

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/abstract.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ define([
407407
this.bubble('error', message);
408408

409409
//TODO: Implement proper result propagation for form
410-
if (this.source && !isValid) {
410+
if (!isValid) {
411411
this.source.set('params.invalid', true);
412412
}
413413

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
/Users/nathsmit/Sites/pagebuilder/magento2-page-builder/dev/tests/integration/testsuite/Magento/PageBuilder/

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/element/image-uploader.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ define([
3535
spyOn(component, 'addFile');
3636

3737
$el.data({
38+
id: 'ABC123--',
3839
'size': 1024,
3940
'mime-type': 'image/png'
4041
});
@@ -46,6 +47,7 @@ define([
4647
});
4748

4849
expect(component.addFile).toHaveBeenCalledWith({
50+
id: 'ABC123--',
4951
type: 'image/png',
5052
name: 'something.png',
5153
url: '/pub/media/something.png',

0 commit comments

Comments
 (0)