Skip to content

Commit ad96f28

Browse files
committed
MC-42892: [Performance] Product image resize function onsave taking long time when saving product images in admin panel
1 parent 1741669 commit ad96f28

File tree

1 file changed

+159
-0
lines changed

1 file changed

+159
-0
lines changed
Lines changed: 159 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
7+
declare(strict_types=1);
8+
9+
namespace Magento\Catalog\Test\Unit\Observer;
10+
11+
use Magento\Catalog\Observer\ImageResizeAfterProductSave;
12+
use Magento\Catalog\Model\Product;
13+
use Magento\Framework\Event;
14+
use Magento\Framework\Event\Observer;
15+
use PHPUnit\Framework\MockObject\MockObject;
16+
use PHPUnit\Framework\TestCase;
17+
use Magento\Framework\App\State;
18+
use Magento\MediaStorage\Service\ImageResize;
19+
use Magento\MediaStorage\Service\ImageResizeScheduler;
20+
use Magento\Catalog\Model\Config\CatalogMediaConfig;
21+
use Magento\Framework\DataObject;
22+
23+
class ImageResizeAfterProductSaveTest extends TestCase
24+
{
25+
/**
26+
* @var Observer|MockObject
27+
*/
28+
private $observerMock;
29+
30+
/**
31+
* @var Event|MockObject
32+
*/
33+
private $eventMock;
34+
35+
/**
36+
* @var Product|MockObject
37+
*/
38+
private $productMock;
39+
40+
/**
41+
* @var State|MockObject
42+
*/
43+
private $stateMock;
44+
45+
/**
46+
* @var CatalogMediaConfig|MockObject
47+
*/
48+
private $catalogMediaConfigMock;
49+
50+
/**
51+
* @var ImageResizeScheduler|MockObject
52+
*/
53+
private $imageResizeSchedulerMock;
54+
55+
/**
56+
* @var ImageResize|MockObject
57+
*/
58+
private $imageResizeMock;
59+
60+
/**
61+
* @var string
62+
*/
63+
private $imagePath;
64+
65+
/**
66+
* @inheritdoc
67+
*/
68+
protected function setUp(): void
69+
{
70+
$this->imagePath = 'path/to/image.jpg';
71+
$images = [new DataObject(['file' => $this->imagePath])];
72+
$this->observerMock = $this->createMock(Observer::class);
73+
$this->eventMock = $this->getMockBuilder(Event::class)
74+
->disableOriginalConstructor()
75+
->addMethods(['getProduct'])
76+
->getMock();
77+
$this->productMock = $this->getMockBuilder(Product::class)
78+
->disableOriginalConstructor()
79+
->onlyMethods(['getId', 'getMediaGalleryImages'])
80+
->getMock();
81+
$this->stateMock = $this->getMockBuilder(State::class)
82+
->disableOriginalConstructor()
83+
->onlyMethods(['isAreaCodeEmulated'])
84+
->getMock();
85+
$this->catalogMediaConfigMock = $this->getMockBuilder(CatalogMediaConfig::class)
86+
->disableOriginalConstructor()
87+
->onlyMethods(['getMediaUrlFormat'])
88+
->getMock();
89+
$this->imageResizeSchedulerMock = $this->getMockBuilder(ImageResizeScheduler::class)
90+
->disableOriginalConstructor()
91+
->onlyMethods(['schedule'])
92+
->getMock();
93+
$this->imageResizeMock = $this->getMockBuilder(ImageResize::class)
94+
->disableOriginalConstructor()
95+
->onlyMethods(['resizeFromImageName'])
96+
->getMock();
97+
98+
$this->observerMock
99+
->expects($this->once())
100+
->method('getEvent')
101+
->willReturn($this->eventMock);
102+
$this->eventMock
103+
->expects($this->once())
104+
->method('getProduct')
105+
->willReturn($this->productMock);
106+
$this->productMock
107+
->expects($this->any())
108+
->method('getId')
109+
->willReturn(null);
110+
$this->productMock
111+
->expects($this->once())
112+
->method('getMediaGalleryImages')
113+
->willReturn($images);
114+
}
115+
116+
/**
117+
* Test observer execute method when ImageResizeScheduler is called
118+
*/
119+
public function testExecuteImageResizeScheduler(): void
120+
{
121+
$observer = new ImageResizeAfterProductSave(
122+
$this->imageResizeMock,
123+
$this->stateMock,
124+
$this->catalogMediaConfigMock,
125+
$this->imageResizeSchedulerMock,
126+
true
127+
);
128+
$this->imageResizeMock
129+
->expects($this->never())
130+
->method('resizeFromImageName');
131+
$this->imageResizeSchedulerMock
132+
->expects($this->once())
133+
->method('schedule')
134+
->with($this->imagePath);
135+
$observer->execute($this->observerMock);
136+
}
137+
138+
/**
139+
* Test observer execute method when ImageResize is called
140+
*/
141+
public function testExecuteImageResize(): void
142+
{
143+
$observer = new ImageResizeAfterProductSave(
144+
$this->imageResizeMock,
145+
$this->stateMock,
146+
$this->catalogMediaConfigMock,
147+
$this->imageResizeSchedulerMock,
148+
false
149+
);
150+
$this->imageResizeMock
151+
->expects($this->once())
152+
->method('resizeFromImageName')
153+
->with($this->imagePath);
154+
$this->imageResizeSchedulerMock
155+
->expects($this->never())
156+
->method('schedule');
157+
$observer->execute($this->observerMock);
158+
}
159+
}

0 commit comments

Comments
 (0)