Fixed php 8.1 deprecations to pass Integration Tests

Author: anzin

app/code/Magento/Catalog/Helper/Product/View.php

@@ -141,7 +141,9 @@ private function preparePageMetadata(ResultPage $resultPage, $product)
         if ($description) {
             $pageConfig->setDescription($description);
         } else {
-            $pageConfig->setDescription($this->string->substr(strip_tags($product->getDescription()), 0, 255));
+            $productDescription = is_string($product->getDescription()) ?
+                $this->string->substr(strip_tags($product->getDescription()), 0, 255) : '';
+            $pageConfig->setDescription($productDescription);
         }
 
         if ($this->_catalogProduct->canUseCanonicalTag()) {
@@ -184,7 +186,7 @@ public function initProductLayout(ResultPage $resultPage, $product, $params = nu
             $pageConfig->setPageLayout($settings->getPageLayout());
         }
 
-        $urlSafeSku = rawurlencode($product->getSku());
+        $urlSafeSku = is_string($product->getSku()) ? rawurlencode($product->getSku()) : '';
 
         // Load default page handles and page configurations
         if ($params && $params->getBeforeHandles()) {

app/code/Magento/PageCache/Model/System/Config/Backend/Varnish.php

@@ -58,7 +58,7 @@ protected function _afterLoad()
         $currentValue = $this->getValue();
         if (!$currentValue) {
             foreach ($data as $field => $value) {
-                if (strstr($this->getPath(), (string) $field)) {
+                if (is_string($this->getPath()) && strstr($this->getPath(), (string) $field)) {
                     $this->setValue($value);
                     $this->save();
                     break;

app/code/Magento/ReleaseNotification/Model/Condition/CanViewNotification.php

@@ -82,11 +82,9 @@ public function isVisible(array $arguments)
         $cacheKey = self::$cachePrefix . $userId;
         $value = $this->cacheStorage->load($cacheKey);
         if ($value === false) {
-            $value = version_compare(
-                $this->viewerLogger->get($userId)->getLastViewVersion(),
-                $this->productMetadata->getVersion(),
-                '<'
-            );
+            $lastViewVersion = $this->viewerLogger->get($userId)->getLastViewVersion() ?: '';
+            $productMetadataVersion = $this->productMetadata->getVersion() ?: '';
+            $value = version_compare($lastViewVersion, $productMetadataVersion, '<');
             $this->cacheStorage->save(false, $cacheKey);
         }
         return (bool)$value;

app/code/Magento/Sales/Helper/Guest.php

@@ -227,11 +227,14 @@ private function setGuestViewCookie($cookieValue)
      */
     private function loadFromCookie($fromCookie)
     {
+        if (!is_string($fromCookie)) {
+            throw new InputException(__($this->inputExceptionMessage));
+        }
         // phpcs:ignore Magento2.Functions.DiscouragedFunction
         $cookieData = explode(':', base64_decode($fromCookie));
-        $protectCode = isset($cookieData[0]) ? $cookieData[0] : null;
-        $incrementId = isset($cookieData[1]) ? $cookieData[1] : null;
-        if (!empty($protectCode) && !empty($incrementId)) {
+        $protectCode = $cookieData[0] ?? null;
+        $incrementId = $cookieData[1] ?? null;
+        if ($protectCode && $incrementId) {
             $order = $this->getOrderRecord($incrementId);
             if (hash_equals((string)$order->getProtectCode(), $protectCode)) {
                 $this->setGuestViewCookie($fromCookie);

dev/tests/integration/testsuite/Magento/Framework/Image/Adapter/InterfaceTest.php

@@ -115,9 +115,12 @@ protected function _getFixture($pattern)
      */
     protected function _isFormatSupported($image, $adapter)
     {
+        if (!$image || !file_exists($image)) {
+            return false;
+        }
         $data = pathinfo($image);
-        $supportedTypes = $adapter->getSupportedFormats();
-        return $image && file_exists($image) && in_array(strtolower($data['extension']), $supportedTypes);
+
+        return isset($data['extension']) && in_array(strtolower($data['extension']), $adapter->getSupportedFormats());
     }
 
     /**

dev/tests/integration/testsuite/Magento/Framework/Translate/InlineTest.php

@@ -119,7 +119,7 @@ public function processResponseBodyDataProvider()
         $package = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
             \Magento\Framework\View\DesignInterface::class
         )->getDesignTheme()->getPackageCode();
-        $expectedText = str_replace('{{design_package}}', $package, $expectedText);
+        $expectedText = str_replace('{{design_package}}', is_string($package) ? $package : '', $expectedText);
         return [
             'plain text' => ['text with no translations and tags', 'text with no translations and tags'],
             'html string' => [$originalText, $expectedText],

lib/internal/Magento/Framework/DB/Helper/AbstractHelper.php

@@ -63,7 +63,7 @@ protected function getConnection()
      */
     public function escapeLikeValue($value, $options = [])
     {
-        $value = str_replace('\\', '\\\\', $value);
+        $value = is_string($value) ? str_replace('\\', '\\\\', $value) : '';
 
         $replaceFrom = [];
         $replaceTo = [];

lib/internal/Magento/Framework/Filter/StripTags.php

@@ -45,7 +45,8 @@ public function __construct(\Magento\Framework\Escaper $escaper, $allowableTags
      */
     public function filter($value)
     {
-        $result = strip_tags($value, $this->allowableTags);
+        $result = is_string($value) ? strip_tags($value, $this->allowableTags) : '';
+
         return $this->escape ? $this->escaper->escapeHtml($result, $this->allowableTags) : $result;
     }
 }

lib/internal/Magento/Framework/Image/Adapter/Gd2.php

@@ -63,7 +63,7 @@ protected function _reset()
      */
     public function open($filename)
     {
-        if (!file_exists($filename)) {
+        if (!$filename || !file_exists($filename)) {
             throw new FileSystemException(
                 new Phrase('File "%1" does not exist.', [$this->_fileName])
             );
@@ -267,7 +267,7 @@ private function _getCallback($callbackType, $fileType = null, $unsupportedText
      * Returns a color identifier.
      *
      * @param resource &$imageResourceTo
-     * @return int
+     * @return void
      * @throws \InvalidArgumentException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
@@ -293,8 +293,6 @@ private function _fillBackgroundColor(&$imageResourceTo)
                     if (!imagesavealpha($imageResourceTo, true)) {
                         throw new \InvalidArgumentException('Failed to save alpha transparency into PNG image.');
                     }
-
-                    return $transparentAlphaColor;
                 } elseif (false !== $transparentIndex) {
                     // fill image with indexed non-alpha transparency
                     $transparentColor = false;
@@ -309,20 +307,23 @@ private function _fillBackgroundColor(&$imageResourceTo)
                         throw new \InvalidArgumentException('Failed to fill image with transparency.');
                     }
                     imagecolortransparent($imageResourceTo, $transparentColor);
-                    return $transparentColor;
                 }
                 // phpcs:ignore Magento2.CodeAnalysis.EmptyBlock.DetectedCatch
             } catch (\Exception $e) {
                 // fallback to default background color
             }
         }
-        list($r, $g, $b) = $this->_backgroundColor;
-        $color = imagecolorallocate($imageResourceTo, $r, $g, $b);
-        if (!imagefill($imageResourceTo, 0, 0, $color)) {
-            throw new \InvalidArgumentException("Failed to fill image background with color {$r} {$g} {$b}.");
-        }
+        list($red, $green, $blue) = $this->_backgroundColor;
 
-        return $color;
+        if ($imageResourceTo && $red && $green && $blue) {
+            $color = imagecolorallocate($imageResourceTo, $red, $green, $blue);
+
+            if (!$color && !imagefill($imageResourceTo, 0, 0, $color)) {
+                throw new \InvalidArgumentException(
+                    "Failed to fill image background with color {$red} {$green} {$blue}."
+                );
+            }
+        }
     }
 
     /**

lib/internal/Magento/Framework/Serialize/Serializer/Json.php

@@ -34,7 +34,13 @@ public function serialize($data)
      */
     public function unserialize($string)
     {
+        if ($string === null) {
+            throw new \InvalidArgumentException(
+                sprintf('Invalid parameter: string must be a string type, null given.')
+            );
+        }
         $result = json_decode($string, true);
+
         if (json_last_error() !== JSON_ERROR_NONE) {
             throw new \InvalidArgumentException("Unable to unserialize value. Error: " . json_last_error_msg());
         }