MAGETWO-33690: Category page displays outdated prices after catalog price rule is deleted

- codestyle fixes

Author: Roman Ganin

app/code/Magento/CatalogRule/Model/Indexer/AbstractIndexer.php

@@ -25,6 +25,7 @@ abstract class AbstractIndexer implements IndexerActionInterface, MviewActionInt
 
     /**
      * @param IndexBuilder $indexBuilder
+     * @param \Magento\Framework\Event\ManagerInterface $eventManager
      */
     public function __construct(
         IndexBuilder $indexBuilder,

app/code/Magento/CatalogRule/Model/Rule.php

@@ -163,7 +163,7 @@ class Rule extends \Magento\Rule\Model\AbstractModel
      * @param \Magento\CatalogRule\Helper\Data $catalogRuleData
      * @param \Magento\Framework\App\Cache\TypeListInterface $cacheTypesList
      * @param \Magento\Framework\Stdlib\DateTime $dateTime
-     * @param \Magento\CatalogRule\Model\Indexer\Rule\RuleProductProcessor
+     * @param \Magento\CatalogRule\Model\Indexer\Rule\RuleProductProcessor $ruleProductProcessor
      * @param \Magento\Framework\Model\Resource\AbstractResource $resource
      * @param \Magento\Framework\Data\Collection\Db $resourceCollection
      * @param array $relatedCacheTypes

app/code/Magento/CatalogRule/Test/Unit/Model/Indexer/AbstractIndexerTest.php

@@ -23,6 +23,11 @@ class AbstractIndexerTest extends \PHPUnit_Framework_TestCase
      */
     protected $_eventManagerMock;
 
+    /**
+     * Set up test
+     *
+     * @return void
+     */
     protected function setUp()
     {
         $this->_eventManagerMock = $this->getMock('\Magento\Framework\Event\ManagerInterface');
@@ -37,6 +42,11 @@ protected function setUp()
         );
     }
 
+    /**
+     * Test execute
+     *
+     * @return void
+     */
     public function testExecute()
     {
         $ids = [1, 2, 5];
@@ -45,6 +55,11 @@ public function testExecute()
         $this->indexer->execute($ids);
     }
 
+    /**
+     * Test execute full reindex action
+     *
+     * @return void
+     */
     public function testExecuteFull()
     {
         $this->indexBuilder->expects($this->once())->method('reindexFull');
@@ -61,12 +76,19 @@ public function testExecuteFull()
     /**
      * @expectedException \Magento\CatalogRule\CatalogRuleException
      * @expectedExceptionMessage Could not rebuild index for empty products array
+     *
+     * @return void
      */
     public function testExecuteListWithEmptyIds()
     {
         $this->indexer->executeList([]);
     }
 
+    /**
+     * @throws \Magento\CatalogRule\CatalogRuleException
+     *
+     * @return void
+     */
     public function testExecuteList()
     {
         $ids = [1, 2, 5];
@@ -78,12 +100,19 @@ public function testExecuteList()
     /**
      * @expectedException \Magento\CatalogRule\CatalogRuleException
      * @expectedExceptionMessage Could not rebuild index for undefined product
+     *
+     * @return void
      */
     public function testExecuteRowWithEmptyId()
     {
         $this->indexer->executeRow(null);
     }
 
+    /**
+     * @throws \Magento\CatalogRule\CatalogRuleException
+     *
+     * @return void
+     */
     public function testExecuteRow()
     {
         $id = 5;

app/code/Magento/CatalogRule/Test/Unit/Model/RuleTest.php

@@ -51,6 +51,11 @@ class RuleTest extends \PHPUnit_Framework_TestCase
      */
     protected $productModel;
 
+    /**
+     * Set up before test
+     *
+     * @return void
+     */
     protected function setUp()
     {
         $this->storeManager = $this->getMock('Magento\Store\Model\StoreManagerInterface');
@@ -134,6 +139,8 @@ protected function setUp()
     /**
      * @dataProvider dataProviderCallbackValidateProduct
      * @param bool $validate
+     *
+     * @return void
      */
     public function testCallbackValidateProduct($validate)
     {
@@ -180,6 +187,11 @@ public function testCallbackValidateProduct($validate)
         }
     }
 
+    /**
+     * Data provider for callbackValidateProduct test
+     *
+     * @return array
+     */
     public function dataProviderCallbackValidateProduct()
     {
         return [
@@ -188,6 +200,11 @@ public function dataProviderCallbackValidateProduct()
         ];
     }
 
+    /**
+     * Test after delete action
+     *
+     * @return void
+     */
     public function testAfterDelete()
     {
         $indexer = $this->getMock('\Magento\Indexer\Model\IndexerInterface');
@@ -196,6 +213,11 @@ public function testAfterDelete()
         $this->rule->afterDelete();
     }
 
+    /**
+     * Test after update action
+     *
+     * @return void
+     */
     public function testAfterUpdate()
     {
         $this->rule->isObjectNew(false);