Skip to content

Commit ace40f6

Browse files
MAGETWO-67727: DOM batch operation on form submit
1 parent bdbde06 commit ace40f6

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

lib/web/mage/utils/misc.js

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,7 @@ define([
121121
submit: function (options, attrs) {
122122
var form = document.createElement('form'),
123123
data = this.serialize(options.data),
124-
attributes = _.extend({}, defaultAttributes, attrs || {}),
125-
field;
124+
attributes = _.extend({}, defaultAttributes, attrs || {});
126125

127126
if (!attributes.action) {
128127
attributes.action = options.url;
@@ -134,17 +133,17 @@ define([
134133
form.setAttribute(name, value);
135134
});
136135

137-
_.each(data, function (value, name) {
138-
field = document.createElement('input');
139-
140-
field.setAttribute('name', name);
141-
field.setAttribute('type', 'hidden');
142-
143-
field.value = value;
144-
145-
form.appendChild(field);
146-
});
136+
data = _.map(
137+
data,
138+
function (value, name) {
139+
return '<input type="hidden" ' +
140+
'name="' + _.escape(name) + '" ' +
141+
'value="' + _.escape(value) + '"' +
142+
' />';
143+
}
144+
).join('');
147145

146+
form.insertAdjacentHTML('afterbegin', data);
148147
document.body.appendChild(form);
149148

150149
form.submit();

0 commit comments

Comments
 (0)