Skip to content

Commit acaad30

Browse files
author
Oleksii Korshenko
committed
MAGETWO-53676: Magento 2.0.9 Publication
- fixed backward incompatible changes
1 parent 0ad738d commit acaad30

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

app/code/Magento/ConfigurableProduct/Model/ResourceModel/Product/Type/Configurable.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,14 @@ class Configurable extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb
2525
/**
2626
* @param \Magento\Framework\Model\ResourceModel\Db\Context $context
2727
* @param \Magento\Catalog\Model\ResourceModel\Product\Relation $catalogProductRelation
28-
* @param ScopeResolverInterface $scopeResolver
2928
* @param string $connectionName
3029
*/
3130
public function __construct(
3231
\Magento\Framework\Model\ResourceModel\Db\Context $context,
3332
\Magento\Catalog\Model\ResourceModel\Product\Relation $catalogProductRelation,
34-
ScopeResolverInterface $scopeResolver = null,
3533
$connectionName = null
3634
) {
3735
$this->_catalogProductRelation = $catalogProductRelation;
38-
$this->scopeResolver = $scopeResolver;
3936
parent::__construct($context, $connectionName);
4037
}
4138

@@ -252,6 +249,7 @@ public function getAttributeOptions($superAttribute, $productId)
252249

253250
/**
254251
* @return ScopeResolverInterface
252+
* @deprecated
255253
*/
256254
private function getScopeResolver()
257255
{

app/code/Magento/ConfigurableProduct/Model/ResourceModel/Product/Type/Configurable/Attribute/Collection.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\Ab
6666
* @param Configurable $catalogProductTypeConfigurable
6767
* @param \Magento\Catalog\Helper\Data $catalogData
6868
* @param Attribute $resource
69-
* @param ConfigurableResource $configurableResource
7069
* @param \Magento\Framework\DB\Adapter\AdapterInterface $connection
7170
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
7271
*/
@@ -79,13 +78,11 @@ public function __construct(
7978
Configurable $catalogProductTypeConfigurable,
8079
\Magento\Catalog\Helper\Data $catalogData,
8180
Attribute $resource,
82-
ConfigurableResource $configurableResource = null,
8381
\Magento\Framework\DB\Adapter\AdapterInterface $connection = null
8482
) {
8583
$this->_storeManager = $storeManager;
8684
$this->_productTypeConfigurable = $catalogProductTypeConfigurable;
8785
$this->_catalogData = $catalogData;
88-
$this->configurableResource = $configurableResource;
8986
parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $connection, $resource);
9087
}
9188

@@ -332,6 +329,7 @@ public function __wakeup()
332329
* Get Configurable Resource
333330
*
334331
* @return ConfigurableResource
332+
* @deprecated
335333
*/
336334
private function getConfigurableResource()
337335
{

app/code/Magento/ConfigurableProduct/Test/Unit/Model/ResourceModel/Product/Type/ConfigurableTest.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,21 @@ public function testGetConfigurableOptions()
102102
'Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable',
103103
[
104104
'getTable',
105-
'getConnection',
105+
'getConnection'
106106
],
107107
[
108108
$this->getMockBuilder(Context::class)->disableOriginalConstructor()->getMock(),
109-
$this->relation,
110-
$scopeResolver
109+
$this->relation
111110
],
112111
'',
113112
true
114113
);
115114

115+
$reflection = new \ReflectionClass('Magento\ConfigurableProduct\Model\ResourceModel\Product\Type\Configurable');
116+
$reflectionProperty = $reflection->getProperty('scopeResolver');
117+
$reflectionProperty->setAccessible(true);
118+
$reflectionProperty->setValue($configurable, $scopeResolver);
119+
116120
$product = $this->getMockBuilder('Magento\Catalog\Model\Product')
117121
->setMethods(
118122
[

0 commit comments

Comments
 (0)