MAGETWO-65099: [Performance] Optimize validation of swatches attributes

  - Fix phpdocs and method naming

Author: igrybkov

app/code/Magento/Swatches/Model/SwatchAttributeCodes.php

@@ -72,7 +72,7 @@ public function getCodes()
         if ($this->swatchAttributeCodes === null) {
             $swatchAttributeCodesCache = $this->cache->load($this->cacheKey);
             if (false === $swatchAttributeCodesCache) {
-                $swatchAttributeCodes = $this->loadSwatchAttributeCodes();
+                $swatchAttributeCodes = $this->getSwatchAttributeCodes();
                 $this->cache->save(json_encode($swatchAttributeCodes), $this->cacheKey, $this->cacheTags);
             } else {
                 $swatchAttributeCodes = json_decode($swatchAttributeCodesCache, true);
@@ -86,9 +86,11 @@ public function getCodes()
     /**
      * Returns list of known swatch attributes.
      *
+     * Returns a map of id and code for all EAV attributes with swatches
+     *
      * @return array
      */
-    private function loadSwatchAttributeCodes()
+    private function getSwatchAttributeCodes()
     {
         $select = $this->resourceConnection->getConnection()->select()
             ->from(
@@ -108,6 +110,8 @@ private function loadSwatchAttributeCodes()
     /**
      * Returns Select for attributes Ids.
      *
+     * Builds a "Select" object which loads all EAV attributes that has "swatch" options
+     *
      * @return Select
      */
     private function getAttributeIdsSelect()