magento2-login-as-customer/issues/104: Global refactoring

- LoginAsCustomerSales refactoring

Author: naydav

app/code/Magento/LoginAsCustomerSales/Plugin/AuthenticateCustomer.php

@@ -3,7 +3,6 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 declare(strict_types=1);
 
 namespace Magento\LoginAsCustomerSales\Plugin;
@@ -34,7 +33,6 @@ class AuthenticateCustomer
     private $quoteRepository;
 
     /**
-     * AuthenticateCustomer constructor.
      * @param CustomerSession $customerSession
      * @param CheckoutSession $checkoutSession
      * @param CartRepositoryInterface $quoteRepository
@@ -51,9 +49,14 @@ public function __construct(
 
     /**
      * Remove all items from guest shopping cart
+     *
      * @param AuthenticateCustomerInterface $subject
      * @param int $customerId
      * @param int $adminId
+     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function beforeExecute(
         AuthenticateCustomerInterface $subject,
@@ -71,14 +74,17 @@ public function beforeExecute(
     }
 
     /**
-     * Mart customer cart as not guest
-     * @return bool
-     * @throws \Magento\Framework\Exception\LocalizedException
-     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     * Mark customer cart as not guest
+     *
      * @param int $adminId
      * @param AuthenticateCustomerInterface $subject
      * @param bool $result
      * @param int $customerId
+     * @return bool
+     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function afterExecute(
         AuthenticateCustomerInterface $subject,
@@ -87,7 +93,6 @@ public function afterExecute(
         int $adminId
     ) {
         if ($result) {
-            /* Load Customer Quote */
             $this->checkoutSession->loadCustomerQuote();
 
             $quote = $this->checkoutSession->getQuote();

app/code/Magento/LoginAsCustomerSales/composer.json

@@ -14,7 +14,9 @@
         "AFL-3.0"
     ],
     "autoload": {
-        "files": [ "registration.php" ],
+        "files": [
+            "registration.php"
+        ],
         "psr-4": {
             "Magento\\LoginAsCustomerSales\\": ""
         }

app/code/Magento/LoginAsCustomerSales/etc/di.xml

@@ -5,8 +5,10 @@
  * See COPYING.txt for license details.
  */
 -->
-<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
-	<type name="Magento\LoginAsCustomer\Api\AuthenticateCustomerInterface">
-		<plugin disabled="false" name="login_as_customer_sales_authenticate_customer" sortOrder="10" type="Magento\LoginAsCustomerSales\Plugin\AuthenticateCustomer"/>
-	</type>
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
+    <type name="Magento\LoginAsCustomer\Api\AuthenticateCustomerInterface">
+        <plugin name="login_as_customer_sales_authenticate_customer"
+                type="Magento\LoginAsCustomerSales\Plugin\AuthenticateCustomer"/>
+    </type>
 </config>

app/code/Magento/LoginAsCustomerSales/etc/module.xml

@@ -5,13 +5,7 @@
  * See COPYING.txt for license details.
  */
 -->
-<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-	<module name="Magento_LoginAsCustomerSales" setup_version="2.2.1">
-		<sequence>
-			<module name="Magento_LoginAsCustomer"/>
-			<module name="Magento_Customer"/>
-			<module name="Magento_Checkout"/>
-			<module name="Magento_Quote"/>
-		</sequence>
-	</module>
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
+    <module name="Magento_LoginAsCustomerSales"/>
 </config>