Skip to content

Commit ac11c9b

Browse files
author
victor
committed
Use hash_equals to substitute laminas crypt
1 parent 2e22570 commit ac11c9b

File tree

1 file changed

+1
-16
lines changed
  • lib/internal/Magento/Framework/Encryption/Helper

1 file changed

+1
-16
lines changed

lib/internal/Magento/Framework/Encryption/Helper/Security.php

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,6 @@ public static function compareStrings($expected, $actual)
2323
{
2424
$expected = (string) $expected;
2525
$actual = (string) $actual;
26-
27-
if (function_exists('hash_equals')) {
28-
return hash_equals($expected, $actual);
29-
}
30-
31-
$lenExpected = mb_strlen($expected, '8bit');
32-
$lenActual = mb_strlen($actual, '8bit');
33-
$len = min($lenExpected, $lenActual);
34-
35-
$result = 0;
36-
for ($i = 0; $i < $len; $i++) {
37-
$result |= ord($expected[$i]) ^ ord($actual[$i]);
38-
}
39-
$result |= $lenExpected ^ $lenActual;
40-
41-
return ($result === 0);
26+
return hash_equals($expected, $actual);
4227
}
4328
}

0 commit comments

Comments
 (0)