[MCP-584] Invert Config method, update Test and move Option field

Author: aa-kashk

app/code/Magento/Quote/Model/Config.php

@@ -11,11 +11,12 @@
 
 /**
  * Class Config
+ * Toggles Inventory check via Config option
  * @package Magento\Quote\Model
  */
 class Config
 {
-    const XML_PATH_DISABLED = 'cataloginventory/item_options/disabled';
+    const XML_PATH_INVENTORY_CHECK_ENABLED = 'cataloginventory/options/enable_inventory_check';
 
     /** @var ScopeConfigInterface */
     private $config;
@@ -33,8 +34,8 @@ public function __construct(ScopeConfigInterface $config)
      * Check if Inventory check is disabled
      * @return bool
      */
-    public function isDisabled(): bool
+    public function isEnabled(): bool
     {
-        return (bool)$this->config->getValue(self::XML_PATH_DISABLED);
+        return (bool)$this->config->getValue(self::XML_PATH_INVENTORY_CHECK_ENABLED);
     }
 }

app/code/Magento/Quote/Model/ResourceModel/Quote/Item/Collection.php

@@ -291,7 +291,7 @@ protected function _assignProducts(): self
             }
             if (!$item->isDeleted()) {
                 $item->setQtyOptions($qtyOptions)->setProduct($product);
-                if (!$this->config->isDisabled()) {
+                if ($this->config->isEnabled()) {
                     $item->checkData();
                 }
             }

app/code/Magento/Quote/Test/Unit/Model/ResourceModel/Quote/Item/ConfigTest.php

@@ -33,12 +33,30 @@ protected function setUp(): void
         $this->config = new Config($this->configMock);
     }
 
+    /**
+     * @return void
+     */
+    public function testIsEnabled()
+    {
+        $this->assertEquals(true, $this->config->isEnabled());
+    }
+
     /**
      * @return void
      */
     public function testIsDisabled()
     {
-        $this->configMock->expects($this->once())->method('getValue');
-        $this->config->isDisabled();
+        $this->setUpForDisabled();
+        $this->assertEquals(false, $this->config->isEnabled());
+    }
+
+    /**
+     * @return void
+     */
+    private function setUpForDisabled()
+    {
+        $this->configMock = $this->getMockForAbstractClass(ScopeConfigInterface::class);
+        $this->configMock->method('getValue')->willReturn('0');
+        $this->config = new Config($this->configMock);
     }
 }

app/code/Magento/Quote/etc/adminhtml/system.xml

@@ -9,9 +9,9 @@
     <system>
         <section id="cataloginventory">
             <tab>catalog</tab>
-            <group id="item_options"  translate="label comment" type="text" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
-                <field id="disabled" translate="label" type="select" sortOrder="15" showInDefault="1" canRestore="1">
-                    <label>Inventory check is Disabled</label>
+            <group id="options">
+                <field id="enable_inventory_check" translate="label" type="select" sortOrder="60" showInDefault="1" canRestore="1">
+                    <label> Enable Inventory Check On Cart Load</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
             </group>

app/code/Magento/Quote/etc/config.xml

@@ -8,9 +8,9 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Store:etc/config.xsd">
     <default>
         <cataloginventory>
-            <item_options>
-                <disabled>0</disabled>
-            </item_options>
+            <options>
+                <enable_inventory_check>0</enable_inventory_check>
+            </options>
         </cataloginventory>
     </default>
 </config>