MAGETWO-65308: CLI command config:set fails on configurations which requires session

Author: shiftedreality

app/code/Magento/Config/Console/Command/ConfigSet/ProcessorFacade.php

@@ -54,10 +54,13 @@ public function __construct(
     }
 
     /**
+     * Processes config:set command.
+     *
      * @param string $path The configuration path in format group/section/field_name
      * @param string $value The configuration value
      * @param string $scope The configuration scope (default, website, or store)
      * @param string $scopeCode The scope code
+     * @param boolean $lock The lock flag
      * @return string Processor response message
      * @throws LocalizedException If validation or processor failed
      */

app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/ProcessorFacadeTest.php

@@ -0,0 +1,112 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Config\Test\Unit\Console\Command\ConfigSet;
+
+use Magento\Config\Console\Command\ConfigSet\ConfigSetProcessorFactory;
+use Magento\Config\Console\Command\ConfigSet\ConfigSetProcessorInterface;
+use Magento\Config\Console\Command\ConfigSet\ProcessorFacade;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\App\Scope\ValidatorInterface;
+use Magento\Config\Model\Config\PathValidator;
+use PHPUnit_Framework_MockObject_MockObject as Mock;
+
+/**
+ * Test for ProcessorFacade.
+ *
+ * @see ProcessorFacade
+ */
+class ProcessorFacadeTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var ProcessorFacade
+     */
+    private $model;
+
+    /**
+     * @var ValidatorInterface|Mock
+     */
+    private $scopeValidatorMock;
+
+    /**
+     * @var PathValidator|Mock
+     */
+    private $pathValidatorMock;
+
+    /**
+     * @var ConfigSetProcessorFactory|Mock
+     */
+    private $configSetProcessorFactoryMock;
+
+    /**
+     * @var ConfigSetProcessorInterface|Mock
+     */
+    private $processorMock;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp()
+    {
+        $this->scopeValidatorMock = $this->getMockBuilder(ValidatorInterface::class)
+            ->getMockForAbstractClass();
+        $this->pathValidatorMock = $this->getMockBuilder(PathValidator::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->configSetProcessorFactoryMock = $this->getMockBuilder(ConfigSetProcessorFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->processorMock = $this->getMockBuilder(ConfigSetProcessorInterface::class)
+            ->getMockForAbstractClass();
+
+        $this->configSetProcessorFactoryMock->expects($this->any())
+            ->method('create')
+            ->willReturn($this->processorMock);
+
+        $this->model = new ProcessorFacade(
+            $this->scopeValidatorMock,
+            $this->pathValidatorMock,
+            $this->configSetProcessorFactoryMock
+        );
+    }
+
+    public function testProcess()
+    {
+        $this->scopeValidatorMock->expects($this->once())
+            ->method('isValid')
+            ->willReturn(true);
+        $this->configSetProcessorFactoryMock->expects($this->once())
+            ->method('create')
+            ->with(ConfigSetProcessorFactory::TYPE_DEFAULT)
+            ->willReturn($this->processorMock);
+        $this->processorMock->expects($this->once())
+            ->method('process')
+            ->with('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
+
+        $this->assertSame(
+            'Value was saved.',
+            $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, false)
+        );
+    }
+
+    public function testExecuteLock()
+    {
+        $this->scopeValidatorMock->expects($this->once())
+            ->method('isValid')
+            ->willReturn(true);
+        $this->configSetProcessorFactoryMock->expects($this->once())
+            ->method('create')
+            ->with(ConfigSetProcessorFactory::TYPE_LOCK)
+            ->willReturn($this->processorMock);
+        $this->processorMock->expects($this->once())
+            ->method('process')
+            ->with('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
+
+        $this->assertSame(
+            'Value was saved and locked.',
+            $this->model->process('test/test/test', 'test', ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null, true)
+        );
+    }
+}